[PATCH v2 4/4] drm: rcar-du: lvds: Rename pclk enable/disable functions

Tomi Valkeinen tomi.valkeinen at ideasonboard.com
Mon Aug 22 13:56:40 UTC 2022


On 22/08/2022 16:52, Laurent Pinchart wrote:
> Hi Tomi,
> 
> Thank you for the patch.
> 
> On Mon, Aug 22, 2022 at 04:05:12PM +0300, Tomi Valkeinen wrote:
>> From: Tomi Valkeinen <tomi.valkeinen+renesas at ideasonboard.com>
>>
>> Rename LVDS pclk enable/disable functions to match what we use for DSI.
> 
> I'd explain here the rationale for the new names:
> 
> The DU driver uses the rcar_lvds_clk_enable() and
> rcar_lvds_clk_disable() functions enable or disable the pixel clock
> generated by the LVDS encoder, as it requires that clock for proper DU
> operation. Rename the functions by replacing "clk" with "pclk" to make
> it clearer that they related to the pixel clock.
> 
> Then the patch could move to the beginning of the series.

Sounds good to me.

  Tomi


More information about the dri-devel mailing list