[PATCH] drm/msm/dsi: drop the hpd worker

[Abhinav Kumar]

On 8/22/2022 10:44 AM, Dmitry Baryshkov wrote:
> It makes no sense to have the HPD worker in the MSM DSI driver anymore.
> It is only queued from the dsi_host_attach/detach() callbacks, where
> it plays no useful role. Either way the panel or next bridge will be
> present and will report it's status directly.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>

With DRM_CONNECTOR_POLL_HPD removed as part of the PANEL_BRIDGE change, 
this change makes sense and LGTM, hence

Reviewed-by: Abhinav Kumar <quic_abhinavk at quicinc.com>

> ---
>   drivers/gpu/drm/msm/dsi/dsi_host.c | 14 --------------
>   1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index a34078497af1..43bf84e92a7c 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -144,7 +144,6 @@ struct msm_dsi_host {
>   
>   	u32 err_work_state;
>   	struct work_struct err_work;
> -	struct work_struct hpd_work;
>   	struct workqueue_struct *workqueue;
>   
>   	/* DSI 6G TX buffer*/
> @@ -1500,14 +1499,6 @@ static int dsi_cmds2buf_tx(struct msm_dsi_host *msm_host,
>   	return len;
>   }
>   
> -static void dsi_hpd_worker(struct work_struct *work)
> -{
> -	struct msm_dsi_host *msm_host =
> -		container_of(work, struct msm_dsi_host, hpd_work);
> -
> -	drm_helper_hpd_irq_event(msm_host->dev);
> -}
> -
>   static void dsi_err_worker(struct work_struct *work)
>   {
>   	struct msm_dsi_host *msm_host =
> @@ -1697,8 +1688,6 @@ static int dsi_host_attach(struct mipi_dsi_host *host,
>   		return ret;
>   
>   	DBG("id=%d", msm_host->id);
> -	if (msm_host->dev)
> -		queue_work(msm_host->workqueue, &msm_host->hpd_work);
>   
>   	return 0;
>   }
> @@ -1713,8 +1702,6 @@ static int dsi_host_detach(struct mipi_dsi_host *host,
>   	msm_host->device_node = NULL;
>   
>   	DBG("id=%d", msm_host->id);
> -	if (msm_host->dev)
> -		queue_work(msm_host->workqueue, &msm_host->hpd_work);
>   
>   	return 0;
>   }
> @@ -2126,7 +2113,6 @@ int msm_dsi_host_init(struct msm_dsi *msm_dsi)
>   	/* setup workqueue */
>   	msm_host->workqueue = alloc_ordered_workqueue("dsi_drm_work", 0);
>   	INIT_WORK(&msm_host->err_work, dsi_err_worker);
> -	INIT_WORK(&msm_host->hpd_work, dsi_hpd_worker);
>   
>   	msm_dsi->id = msm_host->id;
>