[PATCH 3/6] drm/i915/gsc: GSC firmware loading

[Teres Alexis, Alan Previn]

I only have one minor nits below. Rodrigo already captured other minor issues. Functionally, all LGTM so
Reviewed-by: Alan Previn <alan.previn.teres.alexis at intel.com>

On Mon, 2022-11-21 at 15:16 -0800, Ceraolo Spurio, Daniele wrote:
> GSC FW is loaded by submitting a dedicated command via the GSC engine.
> The memory area used for loading the FW is then re-purposed as local
> memory for the GSC itself, so we use a separate allocation instead of
> using the one where we keep the firmware stored for reload.
> 
> @@ -206,6 +206,7 @@ i915-y += gt/uc/intel_uc.o \
>  	  gt/uc/intel_huc.o \
>  	  gt/uc/intel_huc_debugfs.o \
>  	  gt/uc/intel_huc_fw.o \
> +	  gt/uc/intel_gsc_fw.o \
>  	  gt/uc/intel_gsc_uc.o
> 
Nit: Perhaps while here, you fix above to be alphabetical - i think thats the practice?
> 
>