[PATCH] drm/msm/dpu: Fix memory leak in msm_mdss_parse_data_bus_icc_path

Miaoqian Lin linmq006 at gmail.com
Tue Dec 6 07:55:12 UTC 2022


of_icc_get() alloc resources for path1, we should release it when not
need anymore. Early return when IS_ERR_OR_NULL(path0) may leak path1.
Add icc_put(path1) in the error path to fix this.

Fixes: b9364eed9232 ("drm/msm/dpu: Move min BW request and full BW disable back to mdss")
Signed-off-by: Miaoqian Lin <linmq006 at gmail.com>
---
 drivers/gpu/drm/msm/msm_mdss.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c
index e13c5c12b775..a38fa9a9a3d6 100644
--- a/drivers/gpu/drm/msm/msm_mdss.c
+++ b/drivers/gpu/drm/msm/msm_mdss.c
@@ -49,8 +49,10 @@ static int msm_mdss_parse_data_bus_icc_path(struct device *dev,
 	struct icc_path *path0 = of_icc_get(dev, "mdp0-mem");
 	struct icc_path *path1 = of_icc_get(dev, "mdp1-mem");
 
-	if (IS_ERR_OR_NULL(path0))
+	if (IS_ERR_OR_NULL(path0)) {
+		icc_put(path1);
 		return PTR_ERR_OR_ZERO(path0);
+	}
 
 	msm_mdss->path[0] = path0;
 	msm_mdss->num_paths = 1;
-- 
2.25.1



More information about the dri-devel mailing list