[PATCH v9 07/18] drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices

[Marek Vasut]

On 12/11/22 06:42, Jagan Teki wrote:
> On Sun, Dec 11, 2022 at 7:58 AM Marek Vasut <marex at denx.de> wrote:
>>
>> On 12/9/22 16:23, Jagan Teki wrote:
>>> The child devices in MIPI DSI can be binding with OF-graph
>>> and also via child nodes.
>>>
>>> The OF-graph interface represents the child devices via
>>> remote and associated endpoint numbers like
>>>
>>> dsi {
>>>      compatible = "fsl,imx8mm-mipi-dsim";
>>>
>>>      ports {
>>>        port at 0 {
>>>             reg = <0>;
>>>
>>>             dsi_in_lcdif: endpoint at 0 {
>>>                  reg = <0>;
>>>                  remote-endpoint = <&lcdif_out_dsi>;
>>>             };
>>>        };
>>>
>>>        port at 1 {
>>>             reg = <1>;
>>>
>>>             dsi_out_bridge: endpoint {
>>>                  remote-endpoint = <&bridge_in_dsi>;
>>>             };
>>>        };
>>> };
>>>
>>> The child node interface represents the child devices via
>>> conventional child nodes on given DSI parent like
>>>
>>> dsi {
>>>      compatible = "samsung,exynos5433-mipi-dsi";
>>>
>>>      ports {
>>>           port at 0 {
>>>                reg = <0>;
>>>
>>>                dsi_to_mic: endpoint {
>>>                     remote-endpoint = <&mic_to_dsi>;
>>>                };
>>>           };
>>>      };
>>>
>>>      panel at 0 {
>>>           reg = <0>;
>>>      };
>>> };
>>>
>>> As Samsung DSIM bridge is common DSI IP across all Exynos DSI
>>> and NXP i.MX8M host controllers, this patch adds support to
>>> lookup the child devices whether its bindings on the associated
>>> host represent OF-graph or child node interfaces.
>>>
>>> v9, v8, v7, v6, v5, v4, v3:
>>> * none
>>>
>>> v2:
>>> * new patch
>>
>> This looks like a good candidate for common/helper code which can be
>> reused by other similar drivers.
> 
> Yes, I have responded to the same comment of yours in v7 [1]. It is
> hard to make this code work in a generic way.

It seems the patch adds a for_each...() loop and a function call. Should 
be easy enough to turn that into a helper. What am I missing ?