[PATCH] drm/tegra: sor: Remove redundant error logging

[Deepak R Varma]

A call to platform_get_irq() already prints an error on failure within
its own implementation. So printing another error based on its return
value in the caller is redundant and should be removed. The clean up
also makes if condition block braces unnecessary. Remove that as well.

Issue identified using platform_get_irq.cocci coccicheck script.

Signed-off-by: Deepak R Varma <drv at mailo.com>
---
Please note: I was not able to build this driver since I did not find the
DRM_TEGRA option in menu config. All dependencies listed in the KConfig are
enabled, however, I was still not able to find the DRM_TEGRA module in the
Graphics-Drivers list. Since the proposed change is known, minor and obvious, I
am sending in this patch without build testing.

Any advise on how to enable the DRM_TEGRA module in menuconfig selection list
will be helpful. Thank you.


 drivers/gpu/drm/tegra/sor.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c
index 8af632740673..ceaebd33408d 100644
--- a/drivers/gpu/drm/tegra/sor.c
+++ b/drivers/gpu/drm/tegra/sor.c
@@ -3799,10 +3799,8 @@ static int tegra_sor_probe(struct platform_device *pdev)
 	}

 	err = platform_get_irq(pdev, 0);
-	if (err < 0) {
-		dev_err(&pdev->dev, "failed to get IRQ: %d\n", err);
+	if (err < 0)
 		goto remove;
-	}

 	sor->irq = err;

--
2.34.1