[PATCH 00/16] Enable Colorspace connector property in amdgpu

[Joshua Ashton]

Thanks for this, Harry!

I tested your series with https://github.com/Themaister/Granite + 
test-hdr with my KHR_display + HDR Mesa branch and it works great.

The code also looks good -- I was already fairly familiar with it when I 
rebased it and debugged things previously. (Hence where my random commit 
comes from).

Once the documentation comment is fixed in "[PATCH 07/16] drm/connector: 
Print connector colorspace in state debugfs" this series is Reviewed-By: 
Joshua Ashton <joshua at froggi.es>

- Joshie 🐸✨

On 12/12/22 18:21, Harry Wentland wrote:
> This patchset enables the DP and HDMI infoframe properties
> in amdgpu.
> 
> The first two patches are not completely related to the rest. The
> first patch allows for HDR_OUTPUT_METADATA with EOTFs that are
> unknown in the kernel.
> 
> The second one prints a connector's max_bpc as part of the atomic
> state debugfs print.
> 
> The following patches rework the connector colorspace code to
> 1) allow for easy printing of the colorspace in the drm_atomic
>     state debugfs, and
> 2) allow drivers to specify the supported colorspaces on a
>     connector.
> 
> The rest of the patches deal with the Colorspace enablement
> in amdgpu.
> 
> Since the Colorspace property didn't have an IGT test I added
> one to kms_hdr. The relevant patchset can be found on the IGT
> mailing list or on
> https://gitlab.freedesktop.org/hwentland/igt-gpu-tools/-/tree/hdr-colorimetry
> 
> Since I don't have a DP and HDMI analyzer I could not test this
> end-to-end but someone will test it in the coming days. We'll
> refrain from merging this until we can confirm the DP/HDMI analyzer
> shows the correct infoframe.
> 
> Cc: Pekka Paalanen <ppaalanen at gmail.com>
> Cc: Sebastian Wick <sebastian.wick at redhat.com>
> Cc: Vitaly.Prosyak at amd.com
> Cc: Uma Shankar <uma.shankar at intel.com>
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Cc: Joshua Ashton <joshua at froggi.es>
> Cc: dri-devel at lists.freedesktop.org
> Cc: amd-gfx at lists.freedesktop.org
> 
> Harry Wentland (15):
>    drm/display: Don't block HDR_OUTPUT_METADATA on unknown EOTF
>    drm/connector: print max_requested_bpc in state debugfs
>    drm/connector: Drop COLORIMETRY_NO_DATA
>    drm/connector: Convert DRM_MODE_COLORIMETRY to enum
>    drm/connector: Pull out common create_colorspace_property code
>    drm/connector: Allow drivers to pass list of supported colorspaces
>    drm/connector: Print connector colorspace in state debugfs
>    drm/amd/display: Always pass connector_state to stream validation
>    drm/amd/display: Register Colorspace property for DP and HDMI
>    drm/amd/display: Set colorspace for HDMI infoframe
>    drm/amd/display: Send correct DP colorspace infopacket
>    drm/amd/display: Add support for explicit BT601_YCC
>    drm/amd/display: Add debugfs for testing output colorspace
>    drm/amd/display: Add default case for output_color_space switch
>    drm/amd/display: Don't restrict bpc to 8 bpc
> 
> Joshua Ashton (1):
>    drm/amd/display: Always set crtcinfo from create_stream_for_sink
> 
>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  86 ++++++---
>   .../amd/display/amdgpu_dm/amdgpu_dm_debugfs.c |  57 ++++++
>   drivers/gpu/drm/display/drm_hdmi_helper.c     |   8 +-
>   drivers/gpu/drm/drm_atomic.c                  |   2 +
>   drivers/gpu/drm/drm_connector.c               | 181 ++++++++++--------
>   .../gpu/drm/i915/display/intel_connector.c    |   4 +-
>   drivers/gpu/drm/vc4/vc4_hdmi.c                |   2 +-
>   include/drm/display/drm_dp.h                  |   2 +-
>   include/drm/drm_connector.h                   |  57 +++---
>   9 files changed, 261 insertions(+), 138 deletions(-)
> 
> --
> 2.38.1
>