Re: [PATCH v12 2/5] dt-bindings: msm/dp: add data-lanes and link-frequencies property

[Dmitry Baryshkov]

On 13 December 2022 23:44:05 EET, Kuogee Hsieh <quic_khsieh at quicinc.com> wrote:
>Add both data-lanes and link-frequencies property into endpoint
>
>Changes in v7:
>-- split yaml out of dtsi patch
>-- link-frequencies from link rate to symbol rate
>-- deprecation of old data-lanes property
>
>Changes in v8:
>-- correct Bjorn mail address to kernel.org
>
>Changes in v10:
>-- add menu item to data-lanes and link-frequecnis
>
>Changes in v11:
>-- add endpoint property at port at 1
>
>Changes in v12:
>-- use enum for item at data-lanes and link-frequencies

This is not a full list of changes

>
>Signed-off-by: Kuogee Hsieh <quic_khsieh at quicinc.com>`
>---
> .../bindings/display/msm/dp-controller.yaml        | 30 ++++++++++++++++++++--
> 1 file changed, 28 insertions(+), 2 deletions(-)
>
>diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>index f2515af..8fb9fa5 100644
>--- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>+++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
>@@ -81,6 +81,7 @@ properties:
> 
>   data-lanes:
>     $ref: /schemas/types.yaml#/definitions/uint32-array
>+    deprecated: true
>     minItems: 1
>     maxItems: 4
>     items:
>@@ -96,14 +97,37 @@ properties:
> 
>   ports:
>     $ref: /schemas/graph.yaml#/properties/ports
>+
>     properties:
>       port at 0:
>-        $ref: /schemas/graph.yaml#/properties/port
>+        $ref: "/schemas/graph.yaml#/$defs/port-base"
>         description: Input endpoint of the controller
>+        properties:
>+          endpoint:
>+            $ref: /schemas/media/video-interfaces.yaml#


I'd keep it as is. There are no video properties at this side of the graph.

> 
>       port at 1:
>-        $ref: /schemas/graph.yaml#/properties/port
>+        $ref: "/schemas/graph.yaml#/$defs/port-base"
>         description: Output endpoint of the controller
>+        properties:
>+          endpoint:
>+            $ref: /schemas/media/video-interfaces.yaml#
>+            properties:
>+              data-lanes:
>+                minItems: 1
>+                maxItems: 4
>+                items:
>+                  enum: [ 0, 1, 2, 3 ]
>+
>+              link-frequencies:
>+                minItems: 1
>+                maxItems: 4
>+                items:
>+                  enum: [ 1620000000, 2700000000, 5400000000, 8100000000 ]
>+
>+    required:
>+      - port at 0
>+      - port at 1
> 
> required:
>   - compatible
>@@ -193,6 +217,8 @@ examples:
>                 reg = <1>;
>                 endpoint {
>                     remote-endpoint = <&typec>;
>+                    data-lanes = <0 1>;
>+                    link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>; 
>                 };
>             };
>         };

-- 
With best wishes
Dmitry