[PATCH V5 3/4] drm/panel: Add Magnachip D53E6EA8966 Panel Driver

Linus Walleij linus.walleij at linaro.org
Thu Dec 15 10:37:03 UTC 2022


Hi Chris,

looks good to me, just very minor nitpicks:

On Wed, Dec 14, 2022 at 7:06 PM Chris Morgan <macroalpha82 at gmail.com> wrote:
>
> From: Chris Morgan <macromorgan at hotmail.com>
>
> Support Magnachip D53E6EA8966 based panels such as the Samsung
> AMS495QA01 panel as found on the Anbernic RG503. Note this driver
> supports only the AMS495QA01 today which receives video signals via DSI,
> however it receives commands via 3-wire SPI.

using DBI.

>
> Signed-off-by: Chris Morgan <macromorgan at hotmail.com>
> Signed-off-by: Maya Matuszczyk <maccraft123mc at gmail.com>

Is your Kconfig snippet missing:

        depends on BACKLIGHT_CLASS_DEVICE

?

> +#include <linux/of_device.h>
> +#include <linux/of_graph.h>

Not needed anymore, right?

With these fixed:
Reviewed-by: Linus Walleij <linus.walleij at linaro.org>

Yours,
Linus Walleij


More information about the dri-devel mailing list