[PATCH] drm/imx: move IPUv3 driver into separate subdirectory

Lucas Stach l.stach at pengutronix.de
Fri Dec 16 12:59:54 UTC 2022


Am Freitag, dem 16.12.2022 um 13:03 +0100 schrieb Uwe Kleine-König:
> On Fri, Nov 25, 2022 at 12:25:19PM +0100, Lucas Stach wrote:
> > diff --git a/drivers/gpu/drm/imx/Makefile b/drivers/gpu/drm/imx/Makefile
> > index b644deffe948..909622864716 100644
> > --- a/drivers/gpu/drm/imx/Makefile
> > +++ b/drivers/gpu/drm/imx/Makefile
> > @@ -1,12 +1,4 @@
> > [...]
> >  obj-$(CONFIG_DRM_IMX_DCSS) += dcss/
> > +obj-$(CONFIG_DRM_IMX) += ipuv3/
> 
> I wonder if it would make sense to rename DRM_IMX to DRM_IMX_IPUV3 ?!

The driver will still called imx-drm in the DRM driver name. We can not
change this without breaking the UAPI. Even though in hindsight imx-drm
was a way too generic name, I don't think renaming the Kconfig symbol
or even the driver is worth it as it would lead to more confusion in
the end.

Regards,
Lucas

> 
> > diff --git a/drivers/gpu/drm/imx/ipuv3/Kconfig b/drivers/gpu/drm/imx/ipuv3/Kconfig
> > new file mode 100644
> > index 000000000000..f518eb47a18e
> > --- /dev/null
> > +++ b/drivers/gpu/drm/imx/ipuv3/Kconfig
> > [...]
> > +config DRM_IMX_HDMI
> > +	tristate "Freescale i.MX DRM HDMI"
> > +	select DRM_DW_HDMI
> > +	depends on DRM_IMX && OF
> > +	help
> > +	  Choose this if you want to use HDMI on i.MX6.
> > +
> 
> Trailing empty line could be dropped.
> 
> Best regards
> Uwe
> 



More information about the dri-devel mailing list