[PATCH 8/9] drm/format-helper: Simplify drm_fb_build_fourcc_list()

Javier Martinez Canillas javierm at redhat.com
Tue Dec 20 11:03:58 UTC 2022


On 12/13/22 21:12, Thomas Zimmermann wrote:
> The DRM helper drm_fb_build_fourcc_list() creates a list of color
> formats for primary planes of the generic drivers. Simplify the helper:
> 
>  - It used to mix and filter native and emulated formats as provided
>    by the driver. Now the only emulated format is XRGB8888, which is
>    required as fallback by legacy software. Drop support for emulating
>    any other formats.
>  - Also convert alpha formats to their non-alpha counterparts. Generic
>    drivers don't support primary planes with alpha formats and some
>    DTs incorrectly advertise alpha channels for non-alpha hardware. So
>    only export non-alpha formats for primary planes.
> 
> With the simplified helper, scrap format lists of the affected generic
> drivers. All they need is the firmware buffer's native format, from which
> the helper creates the list of color formats.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> ---

Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat



More information about the dri-devel mailing list