[PATCH 1/2] drm/bridge: ti-sn65dsi83: use dev_err_probe

Alexander Stein alexander.stein at ew.tq-group.com
Mon Feb 7 07:53:24 UTC 2022


sn65dsi83_host_attach is called from probe, so silence message upon
deferred probe. This can happen, e.g. if the bridge driver is built-in, but
the host is built as module.

Signed-off-by: Alexander Stein <alexander.stein at ew.tq-group.com>
---
This might look a bit weird in the first place, but the real benefit is
usage of device_set_deferred_probe_reason() inside dev_err_probe().
Having /sys/kernel/debug/devices_deferred providing more information
actually helped me tracking down an issue.

 drivers/gpu/drm/bridge/ti-sn65dsi83.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
index a88d90f928ce..1f02596d6db4 100644
--- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c
+++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c
@@ -644,8 +644,7 @@ static int sn65dsi83_host_attach(struct sn65dsi83 *ctx)
 
 	host = of_find_mipi_dsi_host_by_node(ctx->host_node);
 	if (!host) {
-		dev_err(dev, "failed to find dsi host\n");
-		return -EPROBE_DEFER;
+		return dev_err_probe(dev, -EPROBE_DEFER, "failed to find dsi host\n");
 	}
 
 	dsi = devm_mipi_dsi_device_register_full(dev, host, &info);
-- 
2.25.1



More information about the dri-devel mailing list