[PATCH 6/8] drm/ast: Initialize encoder and connector for VGA in helper function

Thomas Zimmermann tzimmermann at suse.de
Mon Feb 7 13:04:58 UTC 2022


Hi

Am 03.02.22 um 18:43 schrieb Javier Martinez Canillas:
> On 1/11/22 13:00, Thomas Zimmermann wrote:
>> Move encoder and connector initialization into a single helper and
>> put all related mode-setting structures into a single place. Done in
>> preparation of moving transmitter code into separate helpers. No
>> functional changes.
>>
>> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> 
> Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>
> 
> [snip]
> 
>> -	encoder->possible_crtcs = 1;
> 
> [snip]
> 
>> +	encoder->possible_crtcs = drm_crtc_mask(crtc);
> 
> This is a somewhat unrelated change. It's OK because is fairly simple
> but I would probably still do the cleanups as separate patches.

I'll put this change into a separate patch.

Best regards
Thomas

> 
> Best regards,

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20220207/2e4858b8/attachment.sig>


More information about the dri-devel mailing list