[PATCH v4 3/9] drm: vkms: Replace hardcoded value of `vkms_composer.map` to DRM_FORMAT_MAX_PLANES
Melissa Wen
mwen at igalia.com
Tue Feb 8 10:16:47 UTC 2022
On 01/21, Igor Torrente wrote:
> The `map` vector at `vkms_composer` uses a hardcoded value to define its
> size.
>
> If someday the maximum number of planes increases, this hardcoded value
> can be a problem.
>
> This value is being replaced with the DRM_FORMAT_MAX_PLANES macro.
>
> Signed-off-by: Igor Torrente <igormtorrente at gmail.com>
> ---
> drivers/gpu/drm/vkms/vkms_drv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.h b/drivers/gpu/drm/vkms/vkms_drv.h
> index 9496fdc900b8..0eeea6f93733 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.h
> +++ b/drivers/gpu/drm/vkms/vkms_drv.h
> @@ -30,7 +30,7 @@ struct vkms_writeback_job {
> struct vkms_composer {
> struct drm_framebuffer fb;
> struct drm_rect src, dst;
> - struct dma_buf_map map[4];
> + struct dma_buf_map map[DRM_FORMAT_MAX_PLANES];
Reviewed-by: Melissa Wen <mwen at igalia.com>
> unsigned int offset;
> unsigned int pitch;
> unsigned int cpp;
> --
> 2.30.2
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20220208/ba6ff04a/attachment.sig>
More information about the dri-devel
mailing list