[PATCH v3 5/7] (WIP) drm/solomon: Add SSD130X OLED displays SPI support
Andy Shevchenko
andriy.shevchenko at linux.intel.com
Wed Feb 9 16:40:23 UTC 2022
On Wed, Feb 09, 2022 at 05:07:03PM +0100, Javier Martinez Canillas wrote:
> On 2/9/22 16:17, Andy Shevchenko wrote:
> > On Wed, Feb 09, 2022 at 01:25:46PM +0100, Geert Uytterhoeven wrote:
> >> On Wed, Feb 9, 2022 at 10:12 AM Javier Martinez Canillas
> >> <javierm at redhat.com> wrote:
> >
> > ...
> >
> >>> + .compatible = "solomon,ssd1305fb-spi",
> >>
> >> This needs an update to the DT bindings.
> >> Hence this may be a good time to deprecate the existing
> >> "solomon,ssd130*fb-i2c" compatible values, and switch to
> >> "solomon,ssd130*fb" instead, for both I2C and SPI.
> >
> > Agree!
> >
>
> Did you see my comment about automatic module loading ? I think
> that would be an issue if we use the same compatible for both
> I2C and SPI drivers.
Bug in OF code? This is not a problem in ACPI AFAICT.
--
With Best Regards,
Andy Shevchenko
More information about the dri-devel
mailing list