[PATCH 01/11] drm/ttm: fix resource manager size type and description

Matthew Auld matthew.william.auld at gmail.com
Mon Feb 14 10:27:34 UTC 2022


On Mon, 14 Feb 2022 at 09:34, Christian König
<ckoenig.leichtzumerken at gmail.com> wrote:
>
> That are not pages any more.

"Leave the man->size units as driver defined."

>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>  drivers/gpu/drm/ttm/ttm_resource.c | 6 +++---
>  include/drm/ttm/ttm_resource.h     | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_resource.c b/drivers/gpu/drm/ttm/ttm_resource.c
> index 68344c90549b..ae40e144e728 100644
> --- a/drivers/gpu/drm/ttm/ttm_resource.c
> +++ b/drivers/gpu/drm/ttm/ttm_resource.c
> @@ -153,19 +153,19 @@ void ttm_resource_set_bo(struct ttm_resource *res,
>   *
>   * @man: memory manager object to init
>   * @bdev: ttm device this manager belongs to
> - * @p_size: size managed area in pages.
> + * @size: size of managed resources in arbitary units

s/arbitary/arbitrary/

Reviewed-by: Matthew Auld <matthew.auld at intel.com>

>   *
>   * Initialise core parts of a manager object.
>   */
>  void ttm_resource_manager_init(struct ttm_resource_manager *man,
>                                struct ttm_device *bdev,
> -                              unsigned long p_size)
> +                              uint64_t size)
>  {
>         unsigned i;
>
>         spin_lock_init(&man->move_lock);
>         man->bdev = bdev;
> -       man->size = p_size;
> +       man->size = size;
>
>         for (i = 0; i < TTM_MAX_BO_PRIORITY; ++i)
>                 INIT_LIST_HEAD(&man->lru[i]);
> diff --git a/include/drm/ttm/ttm_resource.h b/include/drm/ttm/ttm_resource.h
> index 69eea9d6399b..555a11fb8a7f 100644
> --- a/include/drm/ttm/ttm_resource.h
> +++ b/include/drm/ttm/ttm_resource.h
> @@ -278,7 +278,7 @@ void ttm_resource_set_bo(struct ttm_resource *res,
>
>  void ttm_resource_manager_init(struct ttm_resource_manager *man,
>                                struct ttm_device *bdev,
> -                              unsigned long p_size);
> +                              uint64_t size);
>
>  int ttm_resource_manager_evict_all(struct ttm_device *bdev,
>                                    struct ttm_resource_manager *man);
> --
> 2.25.1
>


More information about the dri-devel mailing list