[PATCH V2 07/11] drm/bridge: tc358767: Wrap (e)DP aux I2C registration into tc_aux_link_setup()
Lucas Stach
l.stach at pengutronix.de
Fri Feb 18 17:57:34 UTC 2022
Am Freitag, dem 18.02.2022 um 02:00 +0100 schrieb Marek Vasut:
> This bit of code is (e)DP and aux I2C link specific, move it into
> tc_aux_link_setup() to permit cleaner addition of DSI-to-DPI mode.
> No functional change.
>
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Jonas Karlman <jonas at kwiboo.se>
> Cc: Laurent Pinchart <Laurent.pinchart at ideasonboard.com>
> Cc: Maxime Ripard <maxime at cerno.tech>
> Cc: Neil Armstrong <narmstrong at baylibre.com>
> Cc: Sam Ravnborg <sam at ravnborg.org>
Reviewed-by: Lucas Stach <l.stach at pengutronix.de>
> ---
> V2: - New patch
> ---
> drivers/gpu/drm/bridge/tc358767.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
> index 450a472888ba9..55b7f3fb9eec9 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -656,6 +656,12 @@ static int tc_aux_link_setup(struct tc_data *tc)
> if (ret)
> goto err;
>
> + /* Register DP AUX channel */
> + tc->aux.name = "TC358767 AUX i2c adapter";
> + tc->aux.dev = tc->dev;
> + tc->aux.transfer = tc_aux_transfer;
> + drm_dp_aux_init(&tc->aux);
> +
> return 0;
> err:
> dev_err(tc->dev, "tc_aux_link_setup failed: %d\n", ret);
> @@ -1751,12 +1757,6 @@ static int tc_probe(struct i2c_client *client, const struct i2c_device_id *id)
> if (ret)
> return ret;
>
> - /* Register DP AUX channel */
> - tc->aux.name = "TC358767 AUX i2c adapter";
> - tc->aux.dev = tc->dev;
> - tc->aux.transfer = tc_aux_transfer;
> - drm_dp_aux_init(&tc->aux);
> -
> tc->bridge.funcs = &tc_bridge_funcs;
> if (tc->hpd_pin >= 0)
> tc->bridge.ops |= DRM_BRIDGE_OP_DETECT;
More information about the dri-devel
mailing list