[PATCH v3 3/9] gpu: host1x: Add context device management code

[Dmitry Osipenko]

18.02.2022 14:39, Mikko Perttunen пишет:
...
> +/*
> + * Due to an issue with T194 NVENC, only 38 bits can be used.
> + * Anyway, 256GiB of IOVA ought to be enough for anyone.
> + */
> +static dma_addr_t context_device_dma_mask = DMA_BIT_MASK(38);

s/dma_addr_t/u64/ ? Apparently you should get compilation warning on ARM32.

https://elixir.bootlin.com/linux/v5.17-rc4/source/include/linux/device.h#L524

> +int host1x_context_list_init(struct host1x *host1x)
> +{
> +	struct host1x_context_list *cdl = &host1x->context_list;
> +	struct host1x_context *ctx;
> +	struct device_node *node;
> +	int index;

Nitpick: unsigned int

...
> +del_devices:
> +	while (--index >= 0)

Nitpick: while (index--)

...
> +void host1x_context_list_free(struct host1x_context_list *cdl)
> +{
> +	int i;

Nitpick: unsigned int