[PATCH v10 2/4] Documentation/dt: Add descriptions for loongson display controller

[Krzysztof Kozlowski]

On 23/02/2022 14:56, 隋景峰 wrote:
> 
> 
> 
> > -----Original Messages-----
> > From: "Rob Herring" <robh at kernel.org>
> > Sent Time: 2022-02-23 07:02:34 (Wednesday)
> > To: "Sui Jingfeng" <15330273260 at 189.cn>
> > Cc: "Maxime Ripard" <mripard at kernel.org>, "Thomas Zimmermann" <tzimmermann at suse.de>, "Roland Scheidegger" <sroland at vmware.com>, "Zack Rusin" <zackr at vmware.com>, "Christian Gmeiner" <christian.gmeiner at gmail.com>, "David Airlie" <airlied at linux.ie>, "Daniel Vetter" <daniel at ffwll.ch>, "Thomas Bogendoerfer" <tsbogend at alpha.franken.de>, "Dan Carpenter" <dan.carpenter at oracle.com>, "Krzysztof Kozlowski" <krzk at kernel.org>, "Andrey Zhizhikin" <andrey.zhizhikin at leica-geosystems.com>, "Sam Ravnborg" <sam at ravnborg.org>, "David S . Miller" <davem at davemloft.net>, "Jiaxun Yang" <jiaxun.yang at flygoat.com>, "Lucas Stach" <l.stach at pengutronix.de>, "Maarten Lankhorst" <maarten.lankhorst at linux.intel.com>, "Ilia Mirkin" <imirkin at alum.mit.edu>, "Qing Zhang" <zhangqing at loongson.cn>, suijingfeng <suijingfeng at loongson.cn>, linux-mips at vger.kernel.org, linux-kernel at vger.kernel.org, devicetree at vger.kernel.org, dri-devel at lists.freedesktop.org
> > Subject: Re: [PATCH v10 2/4] Documentation/dt: Add descriptions for loongson display controller
> > 
> > On Sun, Feb 20, 2022 at 10:55:52PM +0800, Sui Jingfeng wrote:
> > > From: suijingfeng <suijingfeng at loongson.cn>
> > 
> > Follow the conventions of the subsystem for patch subjects. It should be 
> > evident with 'git log --oneline Documentation/devicetree/bindings/display'.
> > 
> > Something like this:
> > 
> > dt-bindings: display: Add Loongson display controller
> > 
> 
> Hi, 
> 
> We are not a platform device driver, there is no
> of_device_id defined in my driver. In other word, 
> my driver will not bind against devices whose compatible
> is "loongson,ls7a1000-dc". We just parse the device tree
> actively, find necessary information of interest. 
> In this case, can I use the word "dt-bindings" in the commit title?

This is a patch for specific subsystem, so as Rob said, it should follow
subsystem conventions.

The patch itself is a dt-bindings patch, so there is nothing here
special which would encourage for any exception.


> 
> I want to follow the conventions, but get some push back,
> Krzysztof say that he can not see any bindings, these are not bindings.

I said in comment to your patch with DTS, which you called bindings,
that there are no bindings at all in it. Because in your patch with DTS
you did not include bindings, but you called it bindings.

Here, this is a patch with bindings, so your comment "these are not
bindings" is not true.


</suijingfeng at loongson.cn></suijingfeng at loongson.cn></zhangqing at loongson.cn></imirkin at alum.mit.edu></maarten.lankhorst at linux.intel.com></l.stach at pengutronix.de></jiaxun.yang at flygoat.com></davem at davemloft.net></sam at ravnborg.org></andrey.zhizhikin at leica-geosystems.com></krzk at kernel.org></dan.carpenter at oracle.com></tsbogend at alpha.franken.de></daniel at ffwll.ch></airlied at linux.ie></christian.gmeiner at gmail.com></zackr at vmware.com></sroland at vmware.com></tzimmermann at suse.de></mripard at kernel.org></robh at kernel.org>

This link does not work...

> This email and its attachments contain confidential information from Loongson Technology , which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it. 

Such automatic footers do not help. Could you work on a way to avoid them?



Best regards,
Krzysztof