[PATCH] drm/bridge/tc358775: Fix for dual-link LVDS

[Robert Foss]

On Tue, Jan 4, 2022, 17:56 Vinay Simha B N <simhavcs at gmail.com> wrote:

> Robert,
> What is R-b tag?
>

It looks like this Reviewed-by: Name Lastname <email address>

Maybe have a quick look at this document.

https://www.kernel.org/doc/html/v4.17/process/submitting-patches.html


>
> On Tue, Jan 4, 2022 at 7:21 PM Robert Foss <robert.foss at linaro.org> wrote:
> >
> > Jiri: Are you able to test this patch?
> >
> > Vinay: Could you supply a R-b tag, if you feel that it is warranted?
> >
> > On Tue, 14 Dec 2021 at 09:13, Vinay Simha B N <simhavcs at gmail.com>
> wrote:
> > >
> > > Robert,
> > > I do not have the hardware to test this feature. Sorry for the late
> response.
> > >
> > > On Thu, Nov 18, 2021 at 8:20 PM Robert Foss <robert.foss at linaro.org>
> wrote:
> > >>
> > >> + Zhen & Vinay
> > >>
> > >> This patch looks good in itself, but I would like to see a tested by
> > >> tag. At the very least testing for regression in single-link LVDS but
> > >> ideally some third party verification of this patch.
> > >>
> > >> On Wed, 10 Nov 2021 at 23:01, Jiri Vanek <jirivanek1 at gmail.com>
> wrote:
> > >> >
> > >> > Fixed wrong register shift for single/dual link LVDS output.
> > >> >
> > >> > Signed-off-by: Jiri Vanek <jirivanek1 at gmail.com>
> > >> > ---
> > >> >  drivers/gpu/drm/bridge/tc358775.c | 2 +-
> > >> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >> >
> > >> > diff --git a/drivers/gpu/drm/bridge/tc358775.c
> b/drivers/gpu/drm/bridge/tc358775.c
> > >> > index 2272adcc5b4a..1d6ec1baeff2 100644
> > >> > --- a/drivers/gpu/drm/bridge/tc358775.c
> > >> > +++ b/drivers/gpu/drm/bridge/tc358775.c
> > >> > @@ -241,7 +241,7 @@ static inline u32
> TC358775_LVCFG_PCLKDIV(uint32_t val)
> > >> >  }
> > >> >
> > >> >  #define TC358775_LVCFG_LVDLINK__MASK
>  0x00000002
> > >> > -#define TC358775_LVCFG_LVDLINK__SHIFT                        0
> > >> > +#define TC358775_LVCFG_LVDLINK__SHIFT                        1
> > >> >  static inline u32 TC358775_LVCFG_LVDLINK(uint32_t val)
> > >> >  {
> > >> >         return ((val) << TC358775_LVCFG_LVDLINK__SHIFT) &
> > >> > --
> > >> > 2.30.2
> > >> >
> > >
> > >
> > >
> > > --
> > > regards,
> > > vinaysimha
>
>
>
> --
> regards,
> vinaysimha
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20220104/e48f28f2/attachment-0001.htm>