[PATCH] Remove extra device acquisition method of i2c client in lt9611 driver

Zhiming Liu lzmlzmhh at gmail.com
Thu Jan 13 11:21:41 UTC 2022


Hello Robert,

I am new to linux kernel development, thank you very much for your patient
reply.I will attach V2 of patch in the next email.

Best regards
Zhiming Liu

Robert Foss <robert.foss at linaro.org> 于2022年1月13日周四 18:14写道:

> Hello,
>
> Thanks for submitting this cleanup patch.
>
> On Tue, 11 Jan 2022 at 04:41, lzmlzm <lzmlzmhh at gmail.com> wrote:
> >
>
> A commit message is necessary for all changes, no matter how trivial.
>
> > Signed-off-by: lzmlzm <lzmlzmhh at gmail.com>
>
> Is your name listed correctly above? For the 'Signed-off-by' tag to be
> meaningful, a real name needs to be supplied.
>
> > ---
> >  drivers/gpu/drm/bridge/lontium-lt9611.c    | 2 +-
> >  drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c
> b/drivers/gpu/drm/bridge/lontium-lt9611.c
> > index dafb1b47c15f..e0feb4fd9780 100644
> > --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> > +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> > @@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client,
> >         if (!lt9611)
> >                 return -ENOMEM;
> >
> > -       lt9611->dev = &client->dev;
> > +       lt9611->dev = dev;
> >         lt9611->client = client;
> >         lt9611->sleep = false;
> >
> > diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> > index 33f9716da0ee..e50e42312e82 100644
> > --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> > +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> > @@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client,
> >         if (!lt9611uxc)
> >                 return -ENOMEM;
> >
> > -       lt9611uxc->dev = &client->dev;
> > +       lt9611uxc->dev = dev;
> >         lt9611uxc->client = client;
> >         mutex_init(&lt9611uxc->ocm_lock);
> >
> > --
>
> With these two issues fixed, please submit a v2 of this patch.
>
>
> Rob.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20220113/e3486737/attachment-0001.htm>


More information about the dri-devel mailing list