[PATCH v2] mgag200 fix memmapsl configuration in GCTL6 register

Thomas Zimmermann tzimmermann at suse.de
Wed Jan 19 14:55:13 UTC 2022


Hi

Am 19.01.22 um 13:21 schrieb Thomas Zimmermann:
> 
> Appears to be working on my test machine.
> 
> But please rune scripts/checkpatch.pl on the patch before sending it. I 
> get several errors
> 
> WARNING: Possible unwrapped commit description (prefer a maximum 75 
> chars per line)
> 
> #98:
> 
>      0: Enables alpha mode, and the character generator addressing 
> system is
> 
> 
> 
> ERROR: trailing whitespace
> 
> #149: FILE: drivers/gpu/drm/mgag200/mgag200_mode.c:532:
> 
> +^I/* GCTL6 should be 0x05, but we configure memmapsl to 0xb8000 (text 
> mode),^M$
> 
> 
> 
> ERROR: trailing whitespace
> 
> #150: FILE: drivers/gpu/drm/mgag200/mgag200_mode.c:533:
> 
> +^I * so that it doesn't hang when running kexec/kdump on G200_SE rev42.^M$
> 

Thanks a lot, the patch has been merge now. These problems might have 
been caused by my email client.

Best regards
Thomas

> 
> 
> 
> Best regards
> Thomas
> 
> 
>>       WREG_GFX(7, 0x0f);
>>       WREG_GFX(8, 0x0f);
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20220119/568d180a/attachment.sig>


More information about the dri-devel mailing list