[PATCH] drm/vmwgfx: Stop requesting the pci regions

Thomas Zimmermann tzimmermann at suse.de
Thu Jan 20 10:00:32 UTC 2022


Hi

Am 20.01.22 um 05:06 schrieb Zack Rusin:
[...]
>>>
>>> kernel: fb0: switching to vmwgfx from simple
>>> kernel: Console: switching to colour dummy device 80x25
>>> kernel: vmwgfx 0000:00:0f.0: BAR 2: can't reserve [mem 0x78000000-
>>> 0x7fffffff 64bit pref]
>>> kernel: vmwgfx: probe of 0000:00:0f.0 failed with error -16
>>>
>>> leaving the system without a fb driver.
>>
>> OK, I suspect that it would work if you use simpledrm instead of
>> into the kernel binary.
> 
> Yes, simpledrm works fine. BTW, is there any remaining work before
> distros can enable it by default?

It's here and ready for use.

Simpledrm requires DRM to be linked in the kernel. We're modularizing 
DRM helpers to reduce the binary size.

On the distro side, Javier and me are sorting out issue. But it's fairly 
quite and not many problems show up.

> 
>>
>> If that works, would you consider protecting pci_request_region()
>> with
>>    #if not defined(CONFIG_FB_SIMPLE)
>>    #endif
>>
>> with a FIXME comment?
> 
> Yes, I think that's a good compromise. I'll respin the patch with that.

Before you do that, I have one more patch for you to try. It's all the 
changes as before, but now fbdev hot-unplugs the underlying platform 
device from the device hierarchy. The BOOTFB will not consume parts of 
vmwgfx's display memory range any longer. It's now the same behavior as 
with simpledrm.

This works for me with simplefb and efifb on i915 hardware.

Best regards
Thomas

> 
> z

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: v2-0001-RFC-drop-IORESOURCE_BUSY-from-sysfb-code-and-requ.patch
Type: text/x-patch
Size: 8443 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20220120/cd5b4ea4/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20220120/cd5b4ea4/attachment.sig>


More information about the dri-devel mailing list