[PATCH] drm/vmwgfx: Stop requesting the pci regions

Thomas Zimmermann tzimmermann at suse.de
Fri Jan 21 08:44:04 UTC 2022


Hi

Am 20.01.22 um 22:28 schrieb Zack Rusin:
> On Thu, 2022-01-20 at 11:00 +0100, Thomas Zimmermann wrote:
>>>>
>>>> If that works, would you consider protecting pci_request_region()
>>>> with
>>>>     #if not defined(CONFIG_FB_SIMPLE)
>>>>     #endif
>>>>
>>>> with a FIXME comment?
>>>
>>> Yes, I think that's a good compromise. I'll respin the patch with
>>> that.
>>
>> Before you do that, I have one more patch for you to try. It's all
>> the
>> changes as before, but now fbdev hot-unplugs the underlying platform
>> device from the device hierarchy. The BOOTFB will not consume parts
>> of
>> vmwgfx's display memory range any longer. It's now the same behavior
>> as
>> with simpledrm.
>>
>> This works for me with simplefb and efifb on i915 hardware.
> 
> Yea, that works for me too. Both with simpledrm and simplefb. The patch
> looks good too.
> 
> Do you think you'll be able to get this in stable kernels? If not I'll
> still need something for vmwgfx to make kernels between 5.15 and
> whenever this patch gets in boot with fb.

I'll prepare a patchset with these changes. The actual fix is the change 
to fbmem.c. This one should go to stable and should be easy to backport. 
All the other patches are mostly for correctness and can go to 
drm-misc-next only.

Can I add your Tested-by tag to the patches?

Best regards
Thomas

> 
> z

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20220121/633cf104/attachment-0001.sig>


More information about the dri-devel mailing list