[Bug 216143] [bisected] garbled screen when starting X + dmesg cluttered with "[drm:amdgpu_cs_ioctl [amdgpu]] *ERROR* Failed in the dependencies handling -1431655766!"

[bugzilla-daemon at kernel.org]

https://bugzilla.kernel.org/show_bug.cgi?id=216143

--- Comment #7 from Erhard F. (erhard_f at mailbox.org) ---
(In reply to Alex Deucher from comment #5)
> Does this patch help?
> https://patchwork.freedesktop.org/patch/490475/
Had a closer look at the patch as it did not apply on top of v5.19-rc4. Seems
like almost all of the patch diff is already in upstream v5.19-rc4. Only thing
left to patch is:

--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c    2022-07-02 21:59:53.171528202
+0200
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c    2022-07-02 23:12:13.481985665
+0200
@@ -579,16 +579,6 @@ static int amdgpu_cs_parser_bos(struct a
                e->bo_va = amdgpu_vm_bo_find(vm, bo);
        }

-       /* Move fence waiting after getting reservation lock of
-        * PD root. Then there is no need on a ctx mutex lock.
-        */
-       r = amdgpu_ctx_wait_prev_fence(p->ctx, p->entity);
-       if (unlikely(r != 0)) {
-               if (r != -ERESTARTSYS)
-                       DRM_ERROR("amdgpu_ctx_wait_prev_fence failed.\n");
-               goto error_validate;
-       }
-
        amdgpu_cs_get_threshold_for_moves(p->adev, &p->bytes_moved_threshold,
                                          &p->bytes_moved_vis_threshold);
        p->bytes_moved = 0;
@@ -947,7 +937,7 @@ static int amdgpu_cs_ib_fill(struct amdg
        if (parser->job->uf_addr && ring->funcs->no_user_fence)
                return -EINVAL;

-       return 0;
+       return amdgpu_ctx_wait_prev_fence(parser->ctx, parser->entity);
 }

 static int amdgpu_cs_process_fence_dep(struct amdgpu_cs_parser *p,


But applying this on top of v5.19-rc4 does not help either. I still need to
revert 94f4c4965e5513ba624488f4b601d6b385635aec to get X going.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.