[Intel-gfx] [RFC 01/10] drm/i915/vm_bind: Introduce VM_BIND ioctl

[Niranjana Vishwanathapura]

On Thu, Jul 07, 2022 at 03:18:15AM +0200, Andi Shyti wrote:
>Hi,
>
>[...]
>
>> > +/*
>> > + * VM_BIND feature version supported.
>> > + *
>> > + * The following versions of VM_BIND have been defined:
>> > + *
>> > + * 0: No VM_BIND support.
>> > + *
>> > + * 1: In VM_UNBIND calls, the UMD must specify the exact mappings
>> > created
>> > + *    previously with VM_BIND, the ioctl will not support unbinding
>> > multiple
>> > + *    mappings or splitting them. Similarly, VM_BIND calls will not
>> > replace
>> > + *    any existing mappings.
>> > + *
>> > + * 2: The restrictions on unbinding partial or multiple mappings is
>> > + *    lifted, Similarly, binding will replace any mappings in the
>> > given range.
>> > + *
>> > + * See struct drm_i915_gem_vm_bind and struct
>> > drm_i915_gem_vm_unbind.
>> > + */
>> > +#define I915_PARAM_VM_BIND_VERSION     57
>>
>> Perhaps clarify that new versions are always backwards compatible?
>
>how is this 57 coherent with the description above?
>

57 is the next availble I915_PARAM_* number (from i915_drm.h). The
description above is regarding that 'value' it returns.

Niranjana

>Andi