[PATCH v3 00/71] drm/vc4: Fix hotplug for vc4
Thomas Zimmermann
tzimmermann at suse.de
Thu Jul 7 06:48:10 UTC 2022
Hi
Am 29.06.22 um 14:33 schrieb Maxime Ripard:
> Hi,
>
> Here is a series that address multiple issues when trying to unbind/rebind
> vc4-related devices to their drivers.
>
> Most of these issues involve either use-after-free, improper resource
> liberation or similar.
>
> It has been tested on the Pi3 and Pi4, with X and glxgears running and KASAN
> enabled to properly validate our memory accesses.
>
> Pi3 isn't functional after a rebind though, with vblank timeouts occuring. I'm
> not quite sure why at this point, but at least the kernel doesn't completely
> crash now.
>
Jani commented on replacing WARN_ON wit hdrm_WARN_ON. Maybe go through
the patches and make sure that drm print functions are used everwhere.
With this:
Acked-by: Thomas Zimmermann <tzimmermann at suse.de>
for the series.
Best regards
Thomas
> Let me know what you think,
> Maxime
>
> ---
>
> Changes from v2:
> - Rebased on top of next-20220629
> - Fix va arguments on the crtc and encoder init
> - Removed drmm_connector_init_with_ddc and consolidated drm_connector_init*
> - Reworked the doc for drmm_of_get_bridge
>
> Changes from v1:
> - Rebased on top on next-20220622
> - Consolidated the new drmm init helpers with their alloc counterparts
> - Dropped the drmm writeback and simple encoder helpers
> - Clarified the documentation of drm_connector_unregister
> - Removed the drm_connector_unregister usage
> - Fixed a vblank timeout when unbinding
> - Renamed the kref functions in vc4_dsi
> - Collected the tags
>
> Maxime Ripard (71):
> drm/mipi-dsi: Detach devices when removing the host
> drm/crtc: Introduce drmm_crtc_init_with_planes
> drm/encoder: Introduce drmm_encoder_init
> drm/connector: Reorder headers
> drm/connector: Mention the cleanup after drm_connector_init
> drm/connector: Clarify when drm_connector_unregister is needed
> drm/connector: Consolidate Connector Initialization
> drm/connector: Check for destroy implementation
> drm/connector: Introduce drmm_connector_init
> drm/bridge: panel: Introduce drmm_panel_bridge_add
> drm/bridge: panel: Introduce drmm_of_get_bridge
> drm/vc4: drv: Call component_unbind_all()
> drm/vc4: drv: Use drm_dev_unplug
> drm/vc4: crtc: Create vblank reporting function
> drm/vc4: hvs: Protect device resources after removal
> drm/vc4: hvs: Remove planes currently allocated before taking down
> drm/vc4: plane: Take possible_crtcs as an argument
> drm/vc4: crtc: Remove manual plane removal on error
> drm/vc4: plane: Switch to drmm_universal_plane_alloc()
> drm/vc4: crtc: Move debugfs_name to crtc_data
> drm/vc4: crtc: Switch to drmm_kzalloc
> drm/vc4: crtc: Switch to DRM-managed CRTC initialization
> drm/vc4: dpi: Remove vc4_dev dpi pointer
> drm/vc4: dpi: Embed DRM structures into the private structure
> drm/vc4: dpi: Switch to drmm_kzalloc
> drm/vc4: dpi: Return an error if we can't enable our clock
> drm/vc4: dpi: Remove unnecessary drm_of_panel_bridge_remove call
> drm/vc4: dpi: Add action to disable the clock
> drm/vc4: dpi: Switch to DRM-managed encoder initialization
> drm/vc4: dpi: Switch to drmm_of_get_bridge
> drm/vc4: dpi: Protect device resources
> drm/vc4: dsi: Embed DRM structures into the private structure
> drm/vc4: dsi: Switch to DRM-managed encoder initialization
> drm/vc4: dsi: Switch to drmm_of_get_bridge
> drm/vc4: dsi: Fix the driver structure lifetime
> drm/vc4: dsi: Switch to devm_pm_runtime_enable
> drm/vc4: hdmi: Depends on CONFIG_PM
> drm/vc4: hdmi: Rework power up
> drm/vc4: hdmi: Switch to drmm_kzalloc
> drm/vc4: hdmi: Remove call to drm_connector_unregister()
> drm/vc4: hdmi: Switch to DRM-managed encoder initialization
> drm/vc4: hdmi: Switch to DRM-managed connector initialization
> drm/vc4: hdmi: Switch to device-managed ALSA initialization
> drm/vc4: hdmi: Switch to device-managed CEC initialization
> drm/vc4: hdmi: Use a device-managed action for DDC
> drm/vc4: hdmi: Switch to DRM-managed kfree to build regsets
> drm/vc4: hdmi: Use devm to register hotplug interrupts
> drm/vc4: hdmi: Move audio structure offset checks
> drm/vc4: hdmi: Protect device resources after removal
> drm/vc4: hdmi: Switch to devm_pm_runtime_enable
> drm/vc4: txp: Remove vc4_dev txp pointer
> drm/vc4: txp: Remove duplicate regset
> drm/vc4: txp: Switch to drmm_kzalloc
> drm/vc4: txp: Remove call to drm_connector_unregister()
> drm/vc4: txp: Protect device resources
> drm/vc4: vec: Remove vc4_dev vec pointer
> drm/vc4: vec: Embed DRM structures into the private structure
> drm/vc4: vec: Switch to drmm_kzalloc
> drm/vc4: vec: Remove call to drm_connector_unregister()
> drm/vc4: vec: Switch to DRM-managed encoder initialization
> drm/vc4: vec: Switch to DRM-managed connector initialization
> drm/vc4: vec: Protect device resources after removal
> drm/vc4: vec: Switch to devm_pm_runtime_enable
> drm/vc4: debugfs: Protect device resources
> drm/vc4: debugfs: Return an error on failure
> drm/vc4: debugfs: Simplify debugfs registration
> drm/vc4: Switch to drmm_mutex_init
> drm/vc4: perfmon: Add missing mutex_destroy
> drm/vc4: v3d: Stop disabling interrupts
> drm/vc4: v3d: Rework the runtime_pm setup
> drm/vc4: v3d: Switch to devm_pm_runtime_enable
>
> drivers/gpu/drm/bridge/panel.c | 74 ++++
> drivers/gpu/drm/drm_connector.c | 143 +++++--
> drivers/gpu/drm/drm_crtc.c | 93 +++-
> drivers/gpu/drm/drm_encoder.c | 76 +++-
> drivers/gpu/drm/drm_mipi_dsi.c | 1 +
> drivers/gpu/drm/vc4/Kconfig | 1 +
> drivers/gpu/drm/vc4/vc4_bo.c | 33 +-
> drivers/gpu/drm/vc4/vc4_crtc.c | 90 ++--
> drivers/gpu/drm/vc4/vc4_debugfs.c | 71 ++--
> drivers/gpu/drm/vc4/vc4_dpi.c | 131 +++---
> drivers/gpu/drm/vc4/vc4_drv.c | 21 +-
> drivers/gpu/drm/vc4/vc4_drv.h | 47 +-
> drivers/gpu/drm/vc4/vc4_dsi.c | 133 ++++--
> drivers/gpu/drm/vc4/vc4_gem.c | 10 +-
> drivers/gpu/drm/vc4/vc4_hdmi.c | 683 ++++++++++++++++++++++--------
> drivers/gpu/drm/vc4/vc4_hdmi.h | 3 +-
> drivers/gpu/drm/vc4/vc4_hvs.c | 145 ++++++-
> drivers/gpu/drm/vc4/vc4_irq.c | 2 +-
> drivers/gpu/drm/vc4/vc4_perfmon.c | 1 +
> drivers/gpu/drm/vc4/vc4_plane.c | 36 +-
> drivers/gpu/drm/vc4/vc4_txp.c | 55 ++-
> drivers/gpu/drm/vc4/vc4_v3d.c | 65 ++-
> drivers/gpu/drm/vc4/vc4_vec.c | 216 +++++-----
> include/drm/drm_bridge.h | 4 +
> include/drm/drm_connector.h | 5 +
> include/drm/drm_crtc.h | 9 +
> include/drm/drm_encoder.h | 6 +
> 27 files changed, 1514 insertions(+), 640 deletions(-)
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20220707/f834166c/attachment.sig>
More information about the dri-devel
mailing list