[PATCH v10 04/11] drm/i915/gem: selftest should not attempt mmap of private regions

Matthew Auld matthew.auld at intel.com
Fri Jul 8 07:53:43 UTC 2022


On 07/07/2022 21:02, Robert Beckett wrote:
> During testing make can_mmap consider whether the region is private.

Do we still need this with: 938d2fd17d17 ("drm/i915/selftests: skip the 
mman tests for stolen") ?

> 
> Signed-off-by: Robert Beckett <bob.beckett at collabora.com>
> Reviewed-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>
> ---
>   drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
> index 5bc93a1ce3e3..76181e28c75e 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
> @@ -869,6 +869,9 @@ static bool can_mmap(struct drm_i915_gem_object *obj, enum i915_mmap_type type)
>   	struct drm_i915_private *i915 = to_i915(obj->base.dev);
>   	bool no_map;
>   
> +	if (obj->mm.region && obj->mm.region->private)
> +		return false;
> +
>   	if (obj->ops->mmap_offset)
>   		return type == I915_MMAP_TYPE_FIXED;
>   	else if (type == I915_MMAP_TYPE_FIXED)


More information about the dri-devel mailing list