[PATCH v4 02/69] drm/crtc: Introduce drmm_crtc_init_with_planes

kernel test robot lkp at intel.com
Fri Jul 8 13:55:11 UTC 2022


Hi Maxime,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-tip/drm-tip]
[also build test WARNING on linus/master v5.19-rc5 next-20220708]
[cannot apply to drm-misc/drm-misc-next drm-intel/for-linux-next anholt/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Maxime-Ripard/drm-vc4-Fix-hotplug-for-vc4/20220708-181702
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: i386-defconfig (https://download.01.org/0day-ci/archive/20220708/202207082132.6HbjEQPE-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/3ea20c4eef9608edbd62aa2de918e195c38b0704
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Maxime-Ripard/drm-vc4-Fix-hotplug-for-vc4/20220708-181702
        git checkout 3ea20c4eef9608edbd62aa2de918e195c38b0704
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/drm/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp at intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/drm_crtc.c: In function '__drmm_crtc_init_with_planes':
>> drivers/gpu/drm/drm_crtc.c:395:43: warning: function '__drmm_crtc_init_with_planes' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
     395 |                                           name, args);
         |                                           ^~~~


vim +395 drivers/gpu/drm/drm_crtc.c

   381	
   382	static int __drmm_crtc_init_with_planes(struct drm_device *dev,
   383						struct drm_crtc *crtc,
   384						struct drm_plane *primary,
   385						struct drm_plane *cursor,
   386						const struct drm_crtc_funcs *funcs,
   387						const char *name,
   388						va_list args)
   389	{
   390		int ret;
   391	
   392		drm_WARN_ON(dev, funcs && funcs->destroy);
   393	
   394		ret = __drm_crtc_init_with_planes(dev, crtc, primary, cursor, funcs,
 > 395						  name, args);
   396		if (ret)
   397			return ret;
   398	
   399		ret = drmm_add_action_or_reset(dev, drmm_crtc_init_with_planes_cleanup,
   400					       crtc);
   401		if (ret)
   402			return ret;
   403	
   404		return 0;
   405	}
   406	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp


More information about the dri-devel mailing list