[PATCH 1/3] drm/komeda - Add legacy FB support so VT's work as expected

Liviu Dudau liviu.dudau at arm.com
Fri Jul 8 16:03:49 UTC 2022


On Mon, Jun 06, 2022 at 12:47:12PM +0100, carsten.haitzler at foss.arm.com wrote:
> From: Carsten Haitzler <carsten.haitzler at arm.com>
> 
> The komeda driver doesn't come up with a visible text (FB) mode VT by
> default as it was missing legacy FB support. It's useful to have a
> working text VT on a system for debug and general usability, so enable
> it. You can always toggle CONFIG_FRAMEBUFFER_CONSOLE.
> 
> Signed-off-by: Carsten Haitzler <carsten.haitzler at arm.com>

Reviewed-by: Liviu Dudau <liviu.dudau at arm.com>


> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> index e7933930a657..c0c7933a9631 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> @@ -9,6 +9,7 @@
>  #include <linux/platform_device.h>
>  #include <linux/component.h>
>  #include <linux/pm_runtime.h>
> +#include <drm/drm_fb_helper.h>
>  #include <drm/drm_of.h>
>  #include "komeda_dev.h"
>  #include "komeda_kms.h"
> @@ -71,6 +72,7 @@ static int komeda_bind(struct device *dev)
>  	}
>  
>  	dev_set_drvdata(dev, mdrv);
> +	drm_fbdev_generic_setup(&mdrv->kms->base, 32);
>  
>  	return 0;
>  
> -- 
> 2.32.0
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯


More information about the dri-devel mailing list