[PATCH 08/11] video: Provide constants for VGA I/O range
Javier Martinez Canillas
javierm at redhat.com
Mon Jul 11 11:21:40 UTC 2022
On 7/7/22 17:39, Thomas Zimmermann wrote:
> Provide VGA_FB_ constants for the VGA framebuffer I/O range and convert
> fbdev code.
>
I would probably mention in the commit message to that you are renaming
s/VGA_FB_PHYS/VGA_FB_PHYS_BASE and s/VGA_FB_PHYS_LEN/VGA_FB_PHYS_SIZE.
I do agree with the rename and think that makes it much more readable,
but think that's worth to mention the rationale for that change too.
> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
> ---
Reviewed-by: Javier Martinez Canillas <javierm at redhat.com>
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
More information about the dri-devel
mailing list