[PATCH v2 7/9] dt-bindings: msm/dp: mark vdda supplies as deprecated

Dmitry Baryshkov dmitry.baryshkov at linaro.org
Thu Jul 14 10:15:30 UTC 2022


On 14/07/2022 12:38, Krzysztof Kozlowski wrote:
> On 10/07/2022 10:41, Dmitry Baryshkov wrote:
>> The commit fa384dd8b9b8 ("drm/msm/dp: delete vdda regulator related
>> functions from eDP/DP controller") removed support for VDDA supplies
> 
> No such commit exists in next. Do not reference unpublished commits. If
> this is your tree, be sure that it is in next.

Excuse me. It might have changed at some point. I will update the patch 
description in the next revision. The commit in question is 7516351bebc1 
("drm/msm/dp: delete vdda regulator related functions from eDP/DP 
controller")

> 
>> from the DP controller driver. These supplies are now handled by the eDP
>> or QMP PHYs. Mark these properties as deprecated and drop them from the
>> example.
> 
> Right now I cannot judge whether this is correct or not. I don't know
> what's in that commit, but in general driver implementation changes do
> not warrant changes in the binding.

The vdda supplies were initially made a part of DP controller binding, 
however lately they were moved to be a part of eDP/DP PHY binding (as 
this better reflects the hardware). DP driver dropped support for these 
supplies too. Thus I wanted to mark these supplies as deprecated to 
discourage using them in the DTS files.


-- 
With best wishes
Dmitry


More information about the dri-devel mailing list