[PATCH v2 3/5] soc: visconti: Add Toshiba Visconti DNN image processing accelerator
yuji2.ishikawa at toshiba.co.jp
yuji2.ishikawa at toshiba.co.jp
Tue Jul 26 06:10:35 UTC 2022
Hi Greg
Thanks for your comments
> -----Original Message-----
> From: Greg KH <gregkh at linuxfoundation.org>
> Sent: Monday, July 25, 2022 9:48 PM
> To: ishikawa yuji(石川 悠司 ○RDC□AITC○EA開)
> <yuji2.ishikawa at toshiba.co.jp>Hi
> Cc: Rob Herring <robh+dt at kernel.org>; Hans Verkuil <hverkuil at xs4all.nl>;
> iwamatsu nobuhiro(岩松 信洋 □SWC◯ACT)
> <nobuhiro1.iwamatsu at toshiba.co.jp>; Jonathan Corbet <corbet at lwn.net>;
> Sumit Semwal <sumit.semwal at linaro.org>; Christian König
> <christian.koenig at amd.com>; linux-arm-kernel at lists.infradead.org;
> linux-kernel at vger.kernel.org; linux-media at vger.kernel.org;
> dri-devel at lists.freedesktop.org; linaro-mm-sig at lists.linaro.org
> Subject: Re: [PATCH v2 3/5] soc: visconti: Add Toshiba Visconti DNN image
> processing accelerator
>
> On Fri, Jul 22, 2022 at 05:28:56PM +0900, Yuji Ishikawa wrote:
> > Add support to DNN image processing accelerator on Toshiba Visconti ARM
> SoCs.
> > The accelerator is applicable to DNN inference tasks.
> >
> > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa at toshiba.co.jp>
> > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu at toshiba.co.jp>
> > ---
> > v1 -> v2:
> > - applied checkpatch.pl --strict
> > - removed unused code
> > ---
> > drivers/soc/visconti/Kconfig | 6 +
> > drivers/soc/visconti/Makefile | 2 +
> > drivers/soc/visconti/dnn/Makefile | 6 +
> > drivers/soc/visconti/dnn/dnn.c | 523
> +++++++++++++++++++++++++
> > drivers/soc/visconti/dnn/hwd_dnn.c | 183 +++++++++
> > drivers/soc/visconti/dnn/hwd_dnn.h | 68 ++++
> > drivers/soc/visconti/dnn/hwd_dnn_reg.h | 228 +++++++++++
> > drivers/soc/visconti/uapi/dnn.h | 77 ++++
> > 8 files changed, 1093 insertions(+)
> > create mode 100644 drivers/soc/visconti/dnn/Makefile create mode
> > 100644 drivers/soc/visconti/dnn/dnn.c create mode 100644
> > drivers/soc/visconti/dnn/hwd_dnn.c
> > create mode 100644 drivers/soc/visconti/dnn/hwd_dnn.h
> > create mode 100644 drivers/soc/visconti/dnn/hwd_dnn_reg.h
> > create mode 100644 drivers/soc/visconti/uapi/dnn.h
> >
> > diff --git a/drivers/soc/visconti/Kconfig
> > b/drivers/soc/visconti/Kconfig index 8b1378917..a25287d0c 100644
> > --- a/drivers/soc/visconti/Kconfig
> > +++ b/drivers/soc/visconti/Kconfig
> > @@ -1 +1,7 @@
> > +if ARCH_VISCONTI
> > +
> > +config VISCONTI_DNN
> > + bool "Visconti DNN driver"
> > +
>
> We can't take Kconfig options with no help text at all, please provide the
> needed information here.
I'll add detailed description to Kconfig help text.
>
> And why can't this be a module?
There're no special reasons to disable module build.
I'll test module build and add the option.
Regards,
Yuji
More information about the dri-devel
mailing list