[PATCH v2 2/5] soc: visconti: Add Toshiba Visconti image processing accelerator common source

Tue Jul 26 07:02:12 UTC 2022

Hi Greg,

Thank you for your comments.

> -----Original Message-----
> From: Greg KH <gregkh at linuxfoundation.org>
> Sent: Monday, July 25, 2022 9:46 PM
> To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開)
> <yuji2.ishikawa at toshiba.co.jp>
> Cc: Rob Herring <robh+dt at kernel.org>; Hans Verkuil <hverkuil at xs4all.nl>;
> iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ)
> <nobuhiro1.iwamatsu at toshiba.co.jp>; Jonathan Corbet <corbet at lwn.net>;
> Sumit Semwal <sumit.semwal at linaro.org>; Christian König
> <christian.koenig at amd.com>; linux-arm-kernel at lists.infradead.org;
> linux-kernel at vger.kernel.org; linux-media at vger.kernel.org;
> dri-devel at lists.freedesktop.org; linaro-mm-sig at lists.linaro.org
> Subject: Re: [PATCH v2 2/5] soc: visconti: Add Toshiba Visconti image
> processing accelerator common source
> 
> On Fri, Jul 22, 2022 at 05:28:55PM +0900, Yuji Ishikawa wrote:
> > This commit adds common definitions shared among image processing
> > accelerator drivers for Toshiba Visconti SoCs.
> 
> Please wrap your changelog text lines properly at 72 columns.
>
> And you need to provide a lot more information here as to what this is, it's not
> enough to be able to properly review this with just a single sentence.
>

I'll update changelog.

> >
> > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa at toshiba.co.jp>
> > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu at toshiba.co.jp>
> > ---
> > v1 -> v2:
> >   - applied checkpatch.pl --strict
> > ---
> >  drivers/soc/Kconfig               |  1 +
> >  drivers/soc/Makefile              |  1 +
> >  drivers/soc/visconti/Kconfig      |  1 +
> >  drivers/soc/visconti/Makefile     |  6 +++
> >  drivers/soc/visconti/ipa_common.c | 55 +++++++++++++++++++
> > drivers/soc/visconti/ipa_common.h | 18 +++++++
> >  drivers/soc/visconti/uapi/ipa.h   | 90
> +++++++++++++++++++++++++++++++
> >  7 files changed, 172 insertions(+)
> >  create mode 100644 drivers/soc/visconti/Kconfig  create mode 100644
> > drivers/soc/visconti/Makefile  create mode 100644
> > drivers/soc/visconti/ipa_common.c  create mode 100644
> > drivers/soc/visconti/ipa_common.h  create mode 100644
> > drivers/soc/visconti/uapi/ipa.h
> >
> > diff --git a/drivers/soc/Kconfig b/drivers/soc/Kconfig index
> > e8a30c4c5..c99139aa8 100644
> > --- a/drivers/soc/Kconfig
> > +++ b/drivers/soc/Kconfig
> > @@ -22,6 +22,7 @@ source "drivers/soc/tegra/Kconfig"
> >  source "drivers/soc/ti/Kconfig"
> >  source "drivers/soc/ux500/Kconfig"
> >  source "drivers/soc/versatile/Kconfig"
> > +source "drivers/soc/visconti/Kconfig"
> >  source "drivers/soc/xilinx/Kconfig"
> >
> >  endmenu
> > diff --git a/drivers/soc/Makefile b/drivers/soc/Makefile index
> > a05e9fbcd..455b993c2 100644
> > --- a/drivers/soc/Makefile
> > +++ b/drivers/soc/Makefile
> > @@ -28,4 +28,5 @@ obj-$(CONFIG_ARCH_TEGRA)	+= tegra/
> >  obj-y				+= ti/
> >  obj-$(CONFIG_ARCH_U8500)	+= ux500/
> >  obj-$(CONFIG_PLAT_VERSATILE)	+= versatile/
> > +obj-$(CONFIG_ARCH_VISCONTI)	+= visconti/
> >  obj-y				+= xilinx/
> > diff --git a/drivers/soc/visconti/Kconfig
> > b/drivers/soc/visconti/Kconfig new file mode 100644 index
> > 000000000..8b1378917
> > --- /dev/null
> > +++ b/drivers/soc/visconti/Kconfig
> > @@ -0,0 +1 @@
> > +
> > diff --git a/drivers/soc/visconti/Makefile
> > b/drivers/soc/visconti/Makefile new file mode 100644 index
> > 000000000..8d710da08
> > --- /dev/null
> > +++ b/drivers/soc/visconti/Makefile
> > @@ -0,0 +1,6 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +#
> > +# Makefile for the Visconti specific device drivers.
> > +#
> > +
> > +obj-y += ipa_common.o
> > diff --git a/drivers/soc/visconti/ipa_common.c
> > b/drivers/soc/visconti/ipa_common.c
> > new file mode 100644
> > index 000000000..6345f33c5
> > --- /dev/null
> > +++ b/drivers/soc/visconti/ipa_common.c
> > @@ -0,0 +1,55 @@
> > +// SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> 
> Why is this dual-licensed?  I have to ask, and also, have to see some sort of
> justification as to why this is needed.  Doing dual-licensed kernel code is
> tough and a pain and we need to know that you, and your lawyers, understand
> the issues involved here.
>

I'll talk with development members.

> 
> > +/* Toshiba Visconti Image Processing Accelerator Support
> > + *
> > + * (C) Copyright 2022 TOSHIBA CORPORATION
> > + * (C) Copyright 2022 Toshiba Electronic Devices & Storage
> > +Corporation  */
> > +
> > +#include "ipa_common.h"
> > +
> > +int ipa_attach_dmabuf(struct device *dev, int fd, struct
> dma_buf_attachment **a,
> > +		      struct sg_table **s, dma_addr_t *addr, enum
> > +dma_data_direction dma_dir) {
> > +	struct dma_buf_attachment *attachment;
> > +	struct dma_buf *dmabuf;
> > +	struct sg_table *sgt;
> > +	int ret;
> > +
> > +	dmabuf = dma_buf_get(fd);
> > +	if (IS_ERR(dmabuf)) {
> > +		dev_err(dev, "Invalid dmabuf FD\n");
> > +		return PTR_ERR(dmabuf);
> > +	}
> > +	attachment = dma_buf_attach(dmabuf, dev);
> > +
> > +	if (IS_ERR(attachment)) {
> > +		dev_err(dev, "Failed to attach dmabuf\n");
> > +		ret = PTR_ERR(attachment);
> > +		goto err_put;
> > +	}
> > +	sgt = dma_buf_map_attachment(attachment, dma_dir);
> > +	if (IS_ERR(sgt)) {
> > +		dev_err(dev, "Failed to get dmabufs sg_table\n");
> > +		ret = PTR_ERR(sgt);
> > +		goto err_detach;
> > +	}
> > +	if (sgt->nents != 1) {
> > +		dev_err(dev, "Sparse DMA region is unsupported\n");
> > +		ret = -EINVAL;
> > +		goto err_unmap;
> > +	}
> > +
> > +	*addr = sg_dma_address(sgt->sgl);
> > +	*a = attachment;
> > +	*s = sgt;
> > +
> > +	return 0;
> > +
> > +err_unmap:
> > +	dma_buf_unmap_attachment(attachment, sgt, dma_dir);
> > +err_detach:
> > +	dma_buf_detach(dmabuf, attachment);
> > +err_put:
> > +	dma_buf_put(dmabuf);
> > +	return ret;
> > +}
> 
> Why do you have a whole file for one function?  That feels unneeded.
> 

The function ipa_attach_dmabuf() is shared among several accelerator drivers.
Visconti has other 8 kinds of accelerators; Affine, Pyramid, DSPIF, ...
I should have mentioned detail of how ipa_common.c is used. Sorry.

> thanks,
> 
> greg k-h

Regards,
  Yuji