[drm-tip:drm-tip 4/8] drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:1565:27: error: 'drm_primary_helper_destroy' undeclared here (not in a function); did you mean 'drm_plane_helper_destroy'?

kernel test robot lkp at intel.com
Thu Jul 28 06:10:58 UTC 2022


Hi Thomas,

First bad commit (maybe != root cause):

tree:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
head:   df865a97749db8fbb9ec3491f34bf40771ce1f7b
commit: 9c7f5cf088789957dcfb460cca1ab0fb578f2376 [4/8] Merge remote-tracking branch 'drm-misc/drm-misc-next' into drm-tip
config: alpha-randconfig-r003-20220728 (https://download.01.org/0day-ci/archive/20220728/202207281420.Mnf0XrNj-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add drm-tip git://anongit.freedesktop.org/drm/drm-tip
        git fetch --no-tags drm-tip drm-tip
        git checkout 9c7f5cf088789957dcfb460cca1ab0fb578f2376
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash drivers/gpu/drm/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp at intel.com>

All errors (new ones prefixed by >>):

   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:83:31: warning: no previous prototype for 'amd_get_format_info' [-Wmissing-prototypes]
      83 | const struct drm_format_info *amd_get_format_info(const struct drm_mode_fb_cmd2 *cmd)
         |                               ^~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:88:6: warning: no previous prototype for 'fill_blending_from_plane_state' [-Wmissing-prototypes]
      88 | void fill_blending_from_plane_state(const struct drm_plane_state *plane_state,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:152:6: warning: no previous prototype for 'modifier_has_dcc' [-Wmissing-prototypes]
     152 | bool modifier_has_dcc(uint64_t modifier)
         |      ^~~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:157:10: warning: no previous prototype for 'modifier_gfx9_swizzle_mode' [-Wmissing-prototypes]
     157 | unsigned modifier_gfx9_swizzle_mode(uint64_t modifier)
         |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:752:5: warning: no previous prototype for 'fill_plane_buffer_attributes' [-Wmissing-prototypes]
     752 | int fill_plane_buffer_attributes(struct amdgpu_device *adev,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:992:5: warning: no previous prototype for 'dm_plane_helper_check_state' [-Wmissing-prototypes]
     992 | int dm_plane_helper_check_state(struct drm_plane_state *state,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:1046:5: warning: no previous prototype for 'fill_dc_scaling_info' [-Wmissing-prototypes]
    1046 | int fill_dc_scaling_info(struct amdgpu_device *adev,
         |     ^~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:1222:6: warning: no previous prototype for 'handle_cursor_update' [-Wmissing-prototypes]
    1222 | void handle_cursor_update(struct drm_plane *plane,
         |      ^~~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:1565:27: error: 'drm_primary_helper_destroy' undeclared here (not in a function); did you mean 'drm_plane_helper_destroy'?
    1565 |         .destroy        = drm_primary_helper_destroy,
         |                           ^~~~~~~~~~~~~~~~~~~~~~~~~~
         |                           drm_plane_helper_destroy
   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:1576:5: warning: no previous prototype for 'amdgpu_dm_plane_init' [-Wmissing-prototypes]
    1576 | int amdgpu_dm_plane_init(struct amdgpu_display_manager *dm,
         |     ^~~~~~~~~~~~~~~~~~~~
   In file included from drivers/gpu/drm/amd/amdgpu/../display/dc/inc/core_types.h:32,
                    from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_trace.h:41,
                    from drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c:36:
   drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:137:22: warning: 'SYNAPTICS_DEVICE_ID' defined but not used [-Wunused-const-variable=]
     137 | static const uint8_t SYNAPTICS_DEVICE_ID[] = "SYNA";
         |                      ^~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:134:17: warning: 'DP_SINK_BRANCH_DEV_NAME_7580' defined but not used [-Wunused-const-variable=]
     134 | static const u8 DP_SINK_BRANCH_DEV_NAME_7580[] = "7580\x80u";
         |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:132:22: warning: 'DP_SINK_DEVICE_STR_ID_2' defined but not used [-Wunused-const-variable=]
     132 | static const uint8_t DP_SINK_DEVICE_STR_ID_2[] = {7, 1, 8, 7, 5, 0};
         |                      ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/include/ddc_service_types.h:131:22: warning: 'DP_SINK_DEVICE_STR_ID_1' defined but not used [-Wunused-const-variable=]
     131 | static const uint8_t DP_SINK_DEVICE_STR_ID_1[] = {7, 1, 8, 7, 3, 0};
         |                      ^~~~~~~~~~~~~~~~~~~~~~~


vim +1565 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_plane.c

5d945cbcd4b16a Rodrigo Siqueira 2022-07-20  1561  
5d945cbcd4b16a Rodrigo Siqueira 2022-07-20  1562  static const struct drm_plane_funcs dm_plane_funcs = {
5d945cbcd4b16a Rodrigo Siqueira 2022-07-20  1563  	.update_plane	= drm_atomic_helper_update_plane,
5d945cbcd4b16a Rodrigo Siqueira 2022-07-20  1564  	.disable_plane	= drm_atomic_helper_disable_plane,
5d945cbcd4b16a Rodrigo Siqueira 2022-07-20 @1565  	.destroy	= drm_primary_helper_destroy,
5d945cbcd4b16a Rodrigo Siqueira 2022-07-20  1566  	.reset = dm_drm_plane_reset,
5d945cbcd4b16a Rodrigo Siqueira 2022-07-20  1567  	.atomic_duplicate_state = dm_drm_plane_duplicate_state,
5d945cbcd4b16a Rodrigo Siqueira 2022-07-20  1568  	.atomic_destroy_state = dm_drm_plane_destroy_state,
5d945cbcd4b16a Rodrigo Siqueira 2022-07-20  1569  	.format_mod_supported = dm_plane_format_mod_supported,
5d945cbcd4b16a Rodrigo Siqueira 2022-07-20  1570  #ifdef CONFIG_DRM_AMD_DC_HDR
5d945cbcd4b16a Rodrigo Siqueira 2022-07-20  1571  	.atomic_set_property = dm_drm_plane_set_property,
5d945cbcd4b16a Rodrigo Siqueira 2022-07-20  1572  	.atomic_get_property = dm_drm_plane_get_property,
5d945cbcd4b16a Rodrigo Siqueira 2022-07-20  1573  #endif
5d945cbcd4b16a Rodrigo Siqueira 2022-07-20  1574  };
5d945cbcd4b16a Rodrigo Siqueira 2022-07-20  1575  

:::::: The code at line 1565 was first introduced by commit
:::::: 5d945cbcd4b16a29d6470a80dfb19738f9a4319f drm/amd/display: Create a file dedicated to planes

:::::: TO: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
:::::: CC: Alex Deucher <alexander.deucher at amd.com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp


More information about the dri-devel mailing list