[PATCH 00/10] drm: use idr_init_base() over idr_init() if applicable

Danilo Krummrich dakr at redhat.com
Thu Jul 28 14:56:30 UTC 2022


On 7/28/22 16:44, Maxime Ripard wrote:
> On Thu, Jul 28, 2022 at 04:41:41PM +0200, Maxime Ripard wrote:
>> On Fri, 1 Jul 2022 20:52:53 +0200, dakr at redhat.com wrote:
>>> From: Danilo Krummrich <dakr at redhat.com>
>>>
>>> This patch series initializes IDRs with idr_init_base(&idr, 1) rather than
>>> idr_init(&idr) in case for the particular IDR no IDs < 1 are ever requested -
>>> this avoids unnecessary tree walks.
>>>
>>> Danilo Krummrich (10):
>>>    drm/amdgpu: use idr_init_base() to initialize mgr->ctx_handles
>>>    drm/amdgpu: use idr_init_base() to initialize fpriv->bo_list_handles
>>>    drm: use idr_init_base() to initialize master->magic_map
>>>    drm: use idr_init_base() to initialize master->lessee_idr
>>>    drm: use idr_init_base() to initialize mode_config.object_idr
>>>    drm: use idr_init_base() to initialize mode_config.tile_idr
>>>    drm/sis: use idr_init_base() to initialize dev_priv->object_idr
>>>    drm/v3d: use idr_init_base() to initialize v3d_priv->perfmon.idr
>>>    drm/via: use idr_init_base() to initialize dev_priv->object_idr
>>>    drm/todo: remove task for idr_init_base()
>>>
>>> [...]
>>
>> Applied to drm/drm-misc (drm-misc-next).

Thanks.

> 
> The via driver had changed a bit and the patch 9 didn't apply at all.
> I've moved the change to where it looked like it belonged, but you might
> want to double check.

LGTM.

- Danilo
> 
> Maxime



More information about the dri-devel mailing list