[PATCH] drm/i2c: tda9950: Lower severity of log message about missing interrupts

Mark Brown broonie at kernel.org
Mon Jun 6 17:14:36 UTC 2022


The tda9950 driver prints an error message if it is instantiated without
an interrupt being available since the device is non-functional in that
case. Unfortunately due to packaging of tda9950 with tda998x series devices
the tda998x driver unconditionally instantiates a tda9950 so systems with a
tda998x configured without an interrupt will trigger this error message
during boot if tda9950 support is available. Reduce the severity to debug
level so this is less likely to be presented to end users, the information
is still there for system integrators who run into problems.

We could add a check for an interrupt to the tda998x driver instead but
this feels better from an encapsulation point of view, there's still a log
message to help anyone doing system integration.

Signed-off-by: Mark Brown <broonie at kernel.org>
---
 drivers/gpu/drm/i2c/tda9950.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i2c/tda9950.c b/drivers/gpu/drm/i2c/tda9950.c
index 5b03fdd1eaa4..781d5665cd04 100644
--- a/drivers/gpu/drm/i2c/tda9950.c
+++ b/drivers/gpu/drm/i2c/tda9950.c
@@ -397,7 +397,7 @@ static int tda9950_probe(struct i2c_client *client,
 
 	/* We must have an interrupt to be functional. */
 	if (client->irq <= 0) {
-		dev_err(&client->dev, "driver requires an interrupt\n");
+		dev_dbg(&client->dev, "driver requires an interrupt\n");
 		return -ENXIO;
 	}
 
-- 
2.30.2



More information about the dri-devel mailing list