[PATCH 2/3] drm/msm/dpu: fix maxlinewidth for writeback block
Dmitry Baryshkov
dmitry.baryshkov at linaro.org
Wed Jun 15 12:38:11 UTC 2022
On 14/06/2022 22:32, Abhinav Kumar wrote:
> Writeback block for sm8250 was using the default maxlinewidth
> of 2048. But this is not right as it supports upto 4096.
>
> This should have no effect on most resolutions as we are
> still limiting upto maxlinewidth of SSPP for adding the modes.
>
> Fix the maxlinewidth for writeback block on sm8250.
>
> Fixes: 53324b99bd7b ("add writeback blocks to the sm8250 DPU catalog")
> Signed-off-by: Abhinav Kumar <quic_abhinavk at quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> index 400ebceb56bb..dd7537e32f88 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
> @@ -1285,7 +1285,7 @@ static const struct dpu_intf_cfg qcm2290_intf[] = {
> * Writeback blocks config
> *************************************************************/
> #define WB_BLK(_name, _id, _base, _features, _clk_ctrl, \
> - __xin_id, vbif_id, _reg, _wb_done_bit) \
> + __xin_id, vbif_id, _reg, _max_linewidth, _wb_done_bit) \
> { \
> .name = _name, .id = _id, \
> .base = _base, .len = 0x2c8, \
> @@ -1295,13 +1295,13 @@ static const struct dpu_intf_cfg qcm2290_intf[] = {
> .clk_ctrl = _clk_ctrl, \
> .xin_id = __xin_id, \
> .vbif_idx = vbif_id, \
> - .maxlinewidth = DEFAULT_DPU_LINE_WIDTH, \
> + .maxlinewidth = _max_linewidth, \
> .intr_wb_done = DPU_IRQ_IDX(_reg, _wb_done_bit) \
> }
>
> static const struct dpu_wb_cfg sm8250_wb[] = {
> WB_BLK("wb_2", WB_2, 0x65000, WB_SM8250_MASK, DPU_CLK_CTRL_WB2, 6,
> - VBIF_RT, MDP_SSPP_TOP0_INTR, 4),
> + VBIF_RT, MDP_SSPP_TOP0_INTR, 4096, 4),
> };
>
> /*************************************************************
--
With best wishes
Dmitry
More information about the dri-devel
mailing list