[Freedreno] [PATCH 1/3] drm/msm/dpu: move intf and wb assignment to dpu_encoder_setup_display()

[Abhinav Kumar]

On 6/15/2022 11:21 PM, Dmitry Baryshkov wrote:
> On Thu, 16 Jun 2022 at 09:18, Stephen Boyd <swboyd at chromium.org> wrote:
>>
>> Quoting Abhinav Kumar (2022-06-15 22:59:25)
>>> Hi Dmitry
>>>
>>> On 6/15/2022 10:55 PM, Dmitry Baryshkov wrote:
>>>> On 14/06/2022 22:32, Abhinav Kumar wrote:
>>>>> intf and wb resources are not dependent on the rm global
>>>>> state so need not be allocated during dpu_encoder_virt_atomic_mode_set().
>>>>>
>>>>> Move the allocation of intf and wb resources to
>>>>> dpu_encoder_setup_display()
>>>>> so that we can utilize the hw caps even during atomic_check() phase.
>>>>>
>>>>> Since dpu_encoder_setup_display() already has protection against
>>>>> setting invalid intf_idx and wb_idx, these checks can now
>>>>> be dropped as well.
>>>>>
>>>>> Fixes: e02a559a720f ("make changes to dpu_encoder to support virtual
>>>>> encoder")
>>>>
>>>> Please adjust the Fixes tags in all three commits. I didn't notice this
>>>> beforehand and Stephen has complained.
>>
>> I think Stephen is Stephen Rothwell.
> 
> Ugh, yes. Please excuse me. My brain didn't kick in to notice the name
> aliasing issue.
> 
>>> Is something wrong with the tag? Format and hash looked right to me.
>>
>>          $ git config pretty.fixes
>>          Fixes: %h ("%s")
>>          $ git help fixes
>>          'fixes' is aliased to 'show -s --pretty=fixes'
>>          $ git fixes e02a559a720f
>>          Fixes: e02a559a720f ("drm/msm/dpu: make changes to dpu_encoder to
>> support virtual encoder")
>>
>> it's missing the drm/msm/dpu prefix.
> 
> I have more or less the same setup using a longer format and using the
> git-log instead of git-show. This way I can just do a git fixes
> drivers/gpu/drm/msm and spot the commit in question.
> 
> [pretty]
>          fixes = %C(auto)commit %H%Creset%nFixes: %h (\"%s\")%nAuthor:
> %aN <%aE>%nDate: %aD%nComitter-Date: %cD%n%n%w(0,4,4)%b

Thank you Stephen and Dmitry.

That was a silly mistake to miss the prefix. Will fix it.
>