[PATCH] drm: logicvc: fix error code in logicvc_layer_init()

[Paul Kocialkowski]

Hi,

On Tue 14 Jun 22, 15:08, Dan Carpenter wrote:
> Return -EINVAL if logicvc_layer_formats_lookup() fails.  Don't return
> success.
> 
> Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

Thanks for the fix!

Acked-by: Paul Kocialkowski <paul.kocialkowski at bootlin.com>

Paul

> ---
>  drivers/gpu/drm/logicvc/logicvc_layer.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/logicvc/logicvc_layer.c b/drivers/gpu/drm/logicvc/logicvc_layer.c
> index bae1c7f99569..9c94b67afbed 100644
> --- a/drivers/gpu/drm/logicvc/logicvc_layer.c
> +++ b/drivers/gpu/drm/logicvc/logicvc_layer.c
> @@ -489,6 +489,7 @@ static int logicvc_layer_init(struct logicvc_drm *logicvc,
>  	if (!formats) {
>  		drm_err(drm_dev, "Failed to lookup formats for layer #%d\n",
>  			index);
> +		ret = -EINVAL;
>  		goto error;
>  	}
>  
> -- 
> 2.35.1
> 

-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20220624/6046b124/attachment.sig>