[PATCH] drm: logicvc: Fix uninitialized variable in probe

Maxime Ripard maxime at cerno.tech
Mon Jun 27 08:53:46 UTC 2022


On Fri, Jun 24, 2022 at 04:46:36PM +0200, Paul Kocialkowski wrote:
> Hi,
> 
> On Fri 24 Jun 22, 16:37, Maxime Ripard wrote:
> > Hi,
> > 
> > On Fri, Jun 24, 2022 at 04:35:25PM +0200, Paul Kocialkowski wrote:
> > > On Tue 14 Jun 22, 15:08, Dan Carpenter wrote:
> > > > The "regmap" is supposed to be initialized to NULL but it's used
> > > > without being initialized.
> > > > 
> > > > Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller")
> > > > Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> > > 
> > > Nice catch, thanks a lot!
> > > 
> > > Acked-by: Paul Kocialkowski <paul.kocialkowski at bootlin.com>
> > 
> > Since you have the commit rights to drm-misc, you should apply it
> 
> Absolutely, I'm on my way to doing that.
> 
> Do I need to reply to the emails with a message indicating that I merged them
> or is using the tool sufficient?

Going back on this, but it's fairly easy with b4 to generate the
messages that you applied them.

For example, I'm using:

cat mail | b4 am -t --no-cover -o - -P _ | dim apply-branch drm-misc-fixes

b4 am will retrieve the last version of the patch from lore (and only
the current patch with --no-cover -P _), add the tags (-t) and output it
on stdout (-o -) and pass it to dim apply-branch

Then, you can do

b4 ty -a && git send-email *.thanks && rm *.thanks

And it will send a mail for every patch you applied in the current branch

Maxime


More information about the dri-devel mailing list