[PATCH 00/28] OpenChrome DRM for Linux 5.20

Thomas Zimmermann tzimmermann at suse.de
Tue Jun 28 12:21:29 UTC 2022


Hi

Am 27.06.22 um 23:32 schrieb Sam Ravnborg:
> Hi Kevin/Thomas,
> 
>>
>> I had a brief look over the patches. Even though the code looks fairly rough
>> in places, I think we should get this driver merged ASAP.
> 
> Agreed, we have a had a few cases where we dragged out committing much
> too long time.
> 
> Timing wise, it would be good if we can already hit drm-misc-next right
> _after_ the pull -so we have a full cycle to fix anything before it hits
> mainline.
> 
>> For the old via driver, I think we need a better apprach. IMHO it would be
>> preferable to put the new driver into via/ but keep the old driver there as
>> well.  A build option would control which is being used.
> 
> I assume the user base for via drivers are very small and they have the
> fbdev driver already.
> So I support replacing the current via drm driver as Kevin tries to do.

I don't know if there are still users of the old userspace, but if so I 
would consider this removal a regression. I think the old code supports 
3d and video decoding. Depending on the feature set, 3d support might 
not be useful any longer, but video decoding probably is.  (I might be 
wrong about all this.) IMHO we should not simply remove this at least 
until we can verify that it's no longer useful to anyone.

However, legacy support is trivial. Kevin, please see the attached files 
for two cleanup patches. You're welcome to add them to the start of your 
patchset to get the legacy code out of the way.

Best regards
Thomas


> 
> But anyway we need a patch set that applies without extra
> delete file / add file cycles as the next step.
> 
> 	Sam

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-drm-via-Move-legacy-code-into-single-file.patch
Type: text/x-patch
Size: 228412 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20220628/83c1693b/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-drm-via-Add-new-module-entry-points.patch
Type: text/x-patch
Size: 7376 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20220628/83c1693b/attachment-0003.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/dri-devel/attachments/20220628/83c1693b/attachment-0001.sig>


More information about the dri-devel mailing list