[PATCH] drm/selftests: missing error code in igt_buddy_alloc_smoke()

Christian König christian.koenig at amd.com
Mon Mar 7 16:14:59 UTC 2022


Pushed to drm-misc-next. Just one nit below.

Am 07.03.22 um 15:54 schrieb Arunpravin:
> Reviewed-by:Arunpravin <Arunpravin.PaneerSelvam at amd.com>

Some people are picky about using the full name here.

And you I think we should volunteer you for maintaining that stuff :)

So you might want to get commit rights for drm-misc-next as well.

Christian.

>
> On 07/03/22 6:24 pm, Dan Carpenter wrote:
>> Set the error code to -ENOMEM if drm_random_order() fails.
>>
>> Fixes: e6ff5ef81170 ("drm/selftests: add drm buddy smoke testcase")
>> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
>> ---
>>   drivers/gpu/drm/selftests/test-drm_buddy.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/selftests/test-drm_buddy.c b/drivers/gpu/drm/selftests/test-drm_buddy.c
>> index fa997f89522b..6eba590afa9b 100644
>> --- a/drivers/gpu/drm/selftests/test-drm_buddy.c
>> +++ b/drivers/gpu/drm/selftests/test-drm_buddy.c
>> @@ -488,8 +488,10 @@ static int igt_buddy_alloc_smoke(void *arg)
>>   	}
>>   
>>   	order = drm_random_order(mm.max_order + 1, &prng);
>> -	if (!order)
>> +	if (!order) {
>> +		err = -ENOMEM;
>>   		goto out_fini;
>> +	}
>>   
>>   	for (i = 0; i <= mm.max_order; ++i) {
>>   		struct drm_buddy_block *block;
>>



More information about the dri-devel mailing list