[PATCH] drm/mgag200: Fix PLL setup for g200wb and g200ew

Jocelyn Falempe jfalempe at redhat.com
Tue Mar 8 17:36:31 UTC 2022


On 08/03/2022 18:31, Greg KH wrote:
> On Tue, Mar 08, 2022 at 06:11:11PM +0100, Jocelyn Falempe wrote:
>> commit f86c3ed55920ca1d874758cc290890902a6cffc4 ("drm/mgag200: Split PLL
>> setup into compute and update functions") introduced a regression for
>> g200wb and g200ew.
> 
> No need for all those digits in the sha1, see below:
> 
>> The PLLs are not set up properly, and VGA screen stays
>> black, or displays "out of range" message.
>>
>> MGA1064_WB_PIX_PLLC_N/M/P was mistakenly replaced with
>> MGA1064_PIX_PLLC_N/M/P which have different addresses.
>>
>> Patch tested on a Dell T310 with g200wb
>>
>> Fixes: f86c3ed55920ca1d874758cc290890902a6cffc4
> 
> As per the documentation that line should read:
> 
> Fixes: f86c3ed55920 ("drm/mgag200: Split PLL setup into compute and update functions")

Sorry, I will send a v2 shortly.
> 
> thanks,
> 
> greg k-h
> 



More information about the dri-devel mailing list