[PATCH] drm/vc4: add tracepoints for CL submissions

[Chema Casanova]

El 10/3/22 a las 12:12, Maxime Ripard escribió:
> On Tue, Mar 01, 2022 at 01:58:26PM -0100, Melissa Wen wrote:
>> On 02/25, Maxime Ripard wrote:
>>> Hi Melissa,
>>>
>>> On Tue, Feb 01, 2022 at 08:26:51PM -0100, Melissa Wen wrote:
>>>> Trace submit_cl_ioctl and related IRQs for CL submission and bin/render
>>>> jobs execution. It might be helpful to get a rendering timeline and
>>>> track job throttling.
>>>>
>>>> Signed-off-by: Melissa Wen <mwen at igalia.com>
>>> I'm not really sure what to do about this patch to be honest.
>>>
>>> My understanding is that tracepoints are considered as userspace ABI,
>>> but I can't really judge whether your traces are good enough or if it's
>>> something that will bit us some time down the road.
>> Thanks for taking a look at this patch.
>>
>> So, I followed the same path of tracing CL submissions on v3d. I mean,
>> tracking submit_cl ioctl, points when a job (bin/render) starts it
>> execution, and irqs of completion (bin/render job). We used it to
>> examine job throttling when running Chromium and, therefore, in addition
>> to have the timeline of jobs execution, I show some data submitted in
>> the ioctl to make connections. I think these tracers might be useful for
>> some investigation in the future, but I'm also not sure if all data are
>> necessary to be displayed.
> Yeah, I'm sure that it's useful :)
>
> I don't see anything wrong with that patch, really. What I meant is that
> I don't really have the experience to judge if there's anything wrong in
> the first place :)
>
> If you can get someone with more experience with the v3d driver (Emma,
> Iago maybe?) I'll be definitely be ok merging that patch

I've checked this patch and I've been using these tracepoints.
They have been working properly.

Reviewed-by: Jose Maria Casanova Crespo <jmcasanova at igalia.com>

Regards,

Chema Casanova