[PATCH 1/2] dma-buf: add dma_fence_unwrap
kernel test robot
lkp at intel.com
Fri Mar 11 15:45:37 UTC 2022
Hi "Christian,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.17-rc7 next-20220310]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Christian-K-nig/dma-buf-add-dma_fence_unwrap/20220311-190352
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 79b00034e9dcd2b065c1665c8b42f62b6b80a9be
config: microblaze-randconfig-r011-20220310 (https://download.01.org/0day-ci/archive/20220311/202203112305.WcEordi2-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/088aa14c0f5cad378854823fa661ee145dd2c01b
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Christian-K-nig/dma-buf-add-dma_fence_unwrap/20220311-190352
git checkout 088aa14c0f5cad378854823fa661ee145dd2c01b
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=microblaze SHELL=/bin/bash drivers/dma-buf/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>
All warnings (new ones prefixed by >>):
In file included from drivers/dma-buf/st-dma-fence-unwrap.c:7:
include/linux/dma-fence-unwrap.h: In function 'dma_fence_unwrap_array':
include/linux/dma-fence-unwrap.h:44:25: error: implicit declaration of function 'dma_fence_chain_contained'; did you mean 'dma_fence_chain_init'? [-Werror=implicit-function-declaration]
44 | cursor->array = dma_fence_chain_contained(cursor->chain);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| dma_fence_chain_init
include/linux/dma-fence-unwrap.h:44:23: warning: assignment to 'struct dma_fence *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
44 | cursor->array = dma_fence_chain_contained(cursor->chain);
| ^
include/linux/dma-fence-unwrap.h:46:16: error: implicit declaration of function 'dma_fence_array_first'; did you mean 'dma_fence_array_create'? [-Werror=implicit-function-declaration]
46 | return dma_fence_array_first(cursor->array);
| ^~~~~~~~~~~~~~~~~~~~~
| dma_fence_array_create
include/linux/dma-fence-unwrap.h:46:16: warning: returning 'int' from a function with return type 'struct dma_fence *' makes pointer from integer without a cast [-Wint-conversion]
46 | return dma_fence_array_first(cursor->array);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/dma-fence-unwrap.h: In function 'dma_fence_unwrap_next':
include/linux/dma-fence-unwrap.h:77:15: error: implicit declaration of function 'dma_fence_array_next'; did you mean 'dma_fence_unwrap_next'? [-Werror=implicit-function-declaration]
77 | tmp = dma_fence_array_next(cursor->array, cursor->index);
| ^~~~~~~~~~~~~~~~~~~~
| dma_fence_unwrap_next
include/linux/dma-fence-unwrap.h:77:13: warning: assignment to 'struct dma_fence *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
77 | tmp = dma_fence_array_next(cursor->array, cursor->index);
| ^
drivers/dma-buf/st-dma-fence-unwrap.c: In function 'unwrap_array':
>> drivers/dma-buf/st-dma-fence-unwrap.c:133:13: warning: variable 'err' set but not used [-Wunused-but-set-variable]
133 | int err = 0;
| ^~~
drivers/dma-buf/st-dma-fence-unwrap.c: In function 'unwrap_chain':
drivers/dma-buf/st-dma-fence-unwrap.c:175:13: warning: variable 'err' set but not used [-Wunused-but-set-variable]
175 | int err = 0;
| ^~~
drivers/dma-buf/st-dma-fence-unwrap.c: In function 'unwrap_chain_array':
drivers/dma-buf/st-dma-fence-unwrap.c:217:13: warning: variable 'err' set but not used [-Wunused-but-set-variable]
217 | int err = 0;
| ^~~
cc1: some warnings being treated as errors
vim +/err +133 drivers/dma-buf/st-dma-fence-unwrap.c
128
129 static int unwrap_array(void *arg)
130 {
131 struct dma_fence *fence, *f1, *f2, *array;
132 struct dma_fence_unwrap iter;
> 133 int err = 0;
134
135 f1 = mock_fence();
136 if (!f1)
137 return -ENOMEM;
138
139 f2 = mock_fence();
140 if (!f2) {
141 dma_fence_put(f1);
142 return -ENOMEM;
143 }
144
145 array = mock_array(2, f1, f2);
146 if (!array)
147 return -ENOMEM;
148
149 dma_fence_unwrap_for_each(fence, &iter, array) {
150 if (fence == f1) {
151 f1 = NULL;
152 } else if (fence == f2) {
153 f2 = NULL;
154 } else {
155 pr_err("Unexpected fence!\n");
156 err = -EINVAL;
157 }
158 }
159
160 if (f1 || f2) {
161 pr_err("Not all fences seen!\n");
162 err = -EINVAL;
163 }
164
165 dma_fence_signal(f1);
166 dma_fence_signal(f2);
167 dma_fence_put(array);
168 return 0;
169 }
170
---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
More information about the dri-devel
mailing list