[PATCH 1/2] dt-bindings: display: bridge: ldb: Implement simple NXP i.MX8M LDB bridge
Marek Vasut
marex at denx.de
Sun Mar 13 17:09:49 UTC 2022
On 3/13/22 16:47, Krzysztof Kozlowski wrote:
Hi,
[...]
>> diff --git a/Documentation/devicetree/bindings/display/bridge/nxp,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/nxp,ldb.yaml
>> new file mode 100644
>> index 0000000000000..a05dd05547836
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/display/bridge/nxp,ldb.yaml
>> @@ -0,0 +1,99 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/display/bridge/nxp,ldb.yaml#
>
> In title, description and commit msg you point this is specific to
> i.MX8M, so maybe reflect it in the file name as well.
That's how it is so far, however NXP does recycle their IPs quite a bit
so I don't want to encode the SoC type into the bindings file name. I do
expect them to re-use this bridge somewhere else sooner rather than later.
[...]
The rest is fixed.
[...]
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/imx8mp-clock.h>
>> +
>> + lvds-ldb {
>
> Generic node name, so "bridge" or "display-bridge"
>
>> + #address-cells = <0>;
>> + #size-cells = <0>;
>
> Why do you need address and size cells? This will complain if you test
> your bindings with proper compatible.
Because the subnodes of this bridge have no dimension, so address/size
cells = 0.
I don't understand the second part about "proper compatible", can you
elaborate ?
>> + compatible = "fsl,imx8mp-ldb";
>
> This does not look the same as documented here.
This is the right compatible string, fixed.
More information about the dri-devel
mailing list