[PATCH v4 2/4] drm/panel: Add panel driver for NewVision NV3052C based LCDs

[Sam Ravnborg]

Hi Christophe,

> > > +     { 0x0d, 0x58 },
> > > +     { 0x0e, 0x48 },
> > > +     { 0x0f, 0x38 },
> > > +     { 0x10, 0x2b },
> > > +
> > > +     { 0xff, 0x30 },
> > > +     { 0xff, 0x52 },
> > > +     { 0xff, 0x00 },
> > > +     { 0x36, 0x0a },
> > > +};
> > There are some random (?) empty lines.
> > If they have any significance then a short comment would be nice.
> > If not, then drop the empty lines.
> >
> 
> The empty lines are not random no, to access a different page in the
> init, one must write i.e.   { 0xff, 0x30 }, { 0xff, 0x52 }, { 0xff,
> 0x02 }, to access page 2, so they add a little bit of readability.
Then I suggest to just say what page is is like:

	/* Page 1 */
	{ 0xff, 0x30 },
	...

Etc. then it is obvious this is page boundaries.

	Sam