[PATCH 21/22] drm: Use drm_mode_init() for on-stack modes

Andrzej Hajda andrzej.hajda at intel.com
Tue Mar 22 11:10:46 UTC 2022


On 18.02.2022 11:04, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Initialize on-stack modes with drm_mode_init() to guarantee
> no stack garbage in the list head, or that we aren't copying
> over another mode's list head.
> 
> Based on the following cocci script, with manual fixups:
> @decl@
> identifier M;
> expression E;
> @@
> - struct drm_display_mode M = E;
> + struct drm_display_mode M;
> 
> @@
> identifier decl.M;
> expression decl.E;
> statement S, S1;
> @@
> struct drm_display_mode M;
> ... when != S
> + drm_mode_init(&M, &E);
> +
> S1
> 
> @@
> expression decl.E;
> @@
> - &*E
> + E
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---


Reviewed-by: Andrzej Hajda <andrzej.hajda at intel.com>

Regards
Andrzej


More information about the dri-devel mailing list