[PATCH] dt-bindings: display/msm: another fix for the dpu-qcm2290 example

[Krzysztof Kozlowski]

On 24/03/2022 12:55, Dmitry Baryshkov wrote:
> Make dpu-qcm2290 example really follow the defined schema:
> - Drop qcom,mdss compatible. It's only used for MDP5 devices.
> - Change display controller name to display-controller as specified in
>   the yaml
> 
> Reported-by: Rob Herring <robh at kernel.org>
> Cc: Loic Poulain <loic.poulain at linaro.org>
> Fixes: 164f69d9d45a ("dt-bindings: msm: disp: add yaml schemas for QCM2290 DPU bindings")
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
> ---
>  .../devicetree/bindings/display/msm/dpu-qcm2290.yaml          | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
> index d31483a78eab..6fb7e321f011 100644
> --- a/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dpu-qcm2290.yaml
> @@ -160,7 +160,7 @@ examples:
>      mdss: mdss at 5e00000 {
>          #address-cells = <1>;
>          #size-cells = <1>;
> -        compatible = "qcom,qcm2290-mdss", "qcom,mdss";
> +        compatible = "qcom,qcm2290-mdss";

That's quite unfortunate choice of compatibles. I would assume qcom,mdss
is a generic fallback compatible but it is used in different way - as a
specific compatible for MDP v5. The bindings here are for a newer
device, right?

It's already in the bindings, so not much could be fixed now...

Reviewed-by: Krzysztof Kozlowski <krzk at kernel.org>


Best regards,
Krzysztof